fix: tsconfig not found with TS >= 5.3

[edosrecki]

Fixes #2076
Fixes #2090

[edosrecki]

Added tests as well.

Before fix:

After fix:

[karlhorky]

This can also be marked as "Fixes #2090" I think

[edosrecki]

@karlhorky I marked it but in my opinion author of that issue should close it as duplicate of #2076.

[karlhorky]

author of that issue should close it as duplicate of #2076

Sounds most reasonable, yeah.

But good to have it also here to clean up the other issue, eg. just in case the author is gone now.

[fengmk2]

LGTM

[alyahmedaly]

is there any reason why this PR is not merged?

[edosrecki]

Hi @blakeembrey, @cspotcode

could you please take a look at this PR?

[fengmk2]

Can we get the merge and release before Christmas?

[johnnyreilly]

I have the ability to merge this PR, but I generally don't work on this and so I'm hesitant to, despite requests:

https://twitter.com/karlhorky/status/1732370956335596025

Is there more context that can be shared?

[effektsvk]

@johnnyreilly I debugged the original issue, the problem was that TypeScript introduced a breaking change in the internal API that is used by ts-node. Here is the comment: microsoft/TypeScript#56492 (comment)

(I hope that is what you're looking for 😅)

[johnnyreilly]

I'm more wondering why the typical maintainers haven't picked this up - whilst I have the power to hit merge, this isn't a repo I typically work on and I'm looking to understand what the usual maintainers are feeling.

[peaceshi]

This issue also makes me confused for several hours.
Why not merged until now?
https://github.com/2ndlab/vscode-extension-packages/blob/72c4812d5638ed967e44397736ef5b50cec5da95/src/tools/tsconfig.json#L12C5-L12C5

[torokati44]

This issue also makes me confused for several hours.
Why not merged until now?

+1

This also blocks ruffle-rs/ruffle#14262.

[alumni]

Even if this PR gets merged, we would also need a release.

I'm more wondering why the typical maintainers haven't picked this up - whilst I have the power to hit merge, this isn't a repo I typically work on and I'm looking to understand what the usual maintainers are feeling.

It's open source software, people work on it in their spare time. Maybe they are not even using the latest TS version in their projects, or maybe they don't even work with nodejs anymore. There are a lot of libraries that are like that, e.g. ts-jest is broken since typescript 5.2, typeorm has a ton of pending PRs. I tend not to judge but to have patience :)

[hilleer]

Even if this PR gets merged, we would also need a release.

I'm more wondering why the typical maintainers haven't picked this up - whilst I have the power to hit merge, this isn't a repo I typically work on and I'm looking to understand what the usual maintainers are feeling.

It's open source software, people work on it in their spare time. Maybe they are not even using the latest TS version in their projects, or maybe they don't even work with nodejs anymore. There are a lot of libraries that are like that, e.g. ts-jest is broken since typescript 5.2, typeorm has a ton of pending PRs. I tend not to judge but to have patience :)

Should they be considered the typical maintainers then in this case? 🙂