Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-node-esm / --esm to spawn a child process; decouple config loading from create() #1655

Merged
merged 32 commits into from
Mar 5, 2022

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Feb 22, 2022

Implements and closes #1258
Implements and closes #1429

Fixes #1662

@cspotcode cspotcode changed the title ts-node-esm to spawn a child process ts-node-esm / --esm to spawn a child process; decouple config loading from create() Feb 22, 2022
@cspotcode cspotcode added this to the 10.6.0 or 10.5.1 milestone Feb 22, 2022
@cspotcode cspotcode marked this pull request as ready for review February 22, 2022 19:44
@cspotcode cspotcode marked this pull request as draft February 22, 2022 19:45
@cspotcode cspotcode marked this pull request as ready for review February 22, 2022 19:51
@cspotcode cspotcode marked this pull request as draft February 22, 2022 19:51
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1655 (f1326e2) into main (20cbbf5) will increase coverage by 0.59%.
The diff coverage is 86.45%.

Impacted Files Coverage Δ
dist-raw/node-primordials.js 61.90% <ø> (+2.81%) ⬆️
src/transpilers/swc.ts 75.47% <33.33%> (ø)
src/child/child-require.ts 41.66% <41.66%> (ø)
src/child/spawn-child.ts 75.00% <75.00%> (ø)
src/child/child-loader.ts 88.88% <88.88%> (ø)
src/configuration.ts 91.07% <89.65%> (-0.60%) ⬇️
src/child/child-entrypoint.ts 91.66% <91.66%> (ø)
src/bin.ts 84.91% <95.23%> (+2.48%) ⬆️
src/bin-esm.ts 100.00% <100.00%> (ø)
src/esm.ts 83.33% <100.00%> (+0.64%) ⬆️
... and 3 more

@cspotcode cspotcode marked this pull request as ready for review March 4, 2022 08:07
@cspotcode cspotcode merged commit 0792067 into main Mar 5, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 8, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-node](https://typestrong.org/ts-node) ([source](https://github.com/TypeStrong/ts-node)) | devDependencies | minor | [`10.6.0` -> `10.7.0`](https://renovatebot.com/diffs/npm/ts-node/10.6.0/10.7.0) |

---

### Release Notes

<details>
<summary>TypeStrong/ts-node</summary>

### [`v10.7.0`](https://github.com/TypeStrong/ts-node/releases/v10.7.0)

[Compare Source](TypeStrong/ts-node@v10.6.0...v10.7.0)

Questions about this release? Ask in the official discussion thread: [#&#8203;1680](TypeStrong/ts-node#1680)

**Added**

-   Adds `--esm` flag, option, and `ts-node-esm` binary ([#&#8203;1258](TypeStrong/ts-node#1258), [#&#8203;1655](TypeStrong/ts-node#1655))
    -   Enables full `esm` support; no need for `--loader` nor `NODE_OPTIONS`
    -   Use shebang `#!/usr/bin/env ts-node-esm`, run `ts-node --esm`, or add to your tsconfig.json: `"ts-node": {"esm": true}`

**Changed**

-   Unflag ESM json modules on node >=17.5.0 ([#&#8203;1661](TypeStrong/ts-node#1661), [#&#8203;1665](TypeStrong/ts-node#1665)) [@&#8203;Jamesernator](https://github.com/Jamesernator)
    -   no longer requires `--experimental-json-modules`
-   Lazy-load dependencies to improve startup responsiveness. ([#&#8203;1676](TypeStrong/ts-node#1676))

**Fixed**

-   Fixed bug where "compiler", "transpiler", and swc backend would not resolve relative to the tsconfig.json that declared them ([#&#8203;1662](TypeStrong/ts-node#1662), [#&#8203;1655](TypeStrong/ts-node#1655))
    -   Enables reusable tsconfig.json shared via node module to include necessary dependencies

https://github.com/TypeStrong/ts-node/milestone/11

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1200
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
quisquous pushed a commit to quisquous/cactbot that referenced this pull request Apr 3, 2022
ts-node has native ESM support in [v10.7.0 version](https://github.com/TypeStrong/ts-node/releases/tag/v10.7.0),
although according to the [related PR](TypeStrong/ts-node#1655) says,
they are just spawn a child process that passed `--loader ts-node/esm`
options to node itself.

Also, upgrade `typescript` and `typescript-eslint` to the newer version.
github-actions bot pushed a commit to quisquous/cactbot that referenced this pull request Apr 3, 2022
ts-node has native ESM support in [v10.7.0 version](https://github.com/TypeStrong/ts-node/releases/tag/v10.7.0),
although according to the [related PR](TypeStrong/ts-node#1655) says,
they are just spawn a child process that passed `--loader ts-node/esm`
options to node itself.

Also, upgrade `typescript` and `typescript-eslint` to the newer version. 039a214
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this pull request Apr 3, 2022
…us#4211)

ts-node has native ESM support in [v10.7.0 version](https://github.com/TypeStrong/ts-node/releases/tag/v10.7.0),
although according to the [related PR](TypeStrong/ts-node#1655) says,
they are just spawn a child process that passed `--loader ts-node/esm`
options to node itself.

Also, upgrade `typescript` and `typescript-eslint` to the newer version. 039a214
github-actions bot pushed a commit to SiliconExarch/cactbot that referenced this pull request Apr 3, 2022
…us#4211)

ts-node has native ESM support in [v10.7.0 version](https://github.com/TypeStrong/ts-node/releases/tag/v10.7.0),
although according to the [related PR](TypeStrong/ts-node#1655) says,
they are just spawn a child process that passed `--loader ts-node/esm`
options to node itself.

Also, upgrade `typescript` and `typescript-eslint` to the newer version. 039a214
@cspotcode cspotcode deleted the esm-child-process branch May 7, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment