Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed deprecation warnings on webpack@5. #1195

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Fixed deprecation warnings on webpack@5. #1195

merged 3 commits into from
Oct 13, 2020

Conversation

sanex3339
Copy link
Contributor

Fixed #1194

@sanex3339
Copy link
Contributor Author

Don't sure how to test it, especially because previous checks for webpack@5 were without tests.

johnnyreilly
johnnyreilly reviewed Oct 12, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
johnnyreilly
johnnyreilly reviewed Oct 12, 2020
View reviewed changes
src/instances.ts Outdated Show resolved Hide resolved
johnnyreilly
johnnyreilly reviewed Oct 12, 2020
View reviewed changes
src/instances.ts Outdated Show resolved Hide resolved
@johnnyreilly
Copy link
Member

johnnyreilly commented Oct 12, 2020 •
edited
Loading

Looks good! I've left some comments / suggestions above. (Essentially the same point three times 😄 ) What do you think?

@sanex3339
Copy link
Contributor Author

Looks good! I've left some comments / suggestions above. (Essentially the same point three times 😄 ) What do you think?

Fixed

@johnnyreilly
Copy link
Member

Could you update the version in the package.json to 8.0.5 and add an entry to the package.json please? If the tests pass we're likely safe to ship.

@sanex3339
Copy link
Contributor Author

Could you update the version in the package.json to 8.0.5 and add an entry to the package.json please? If the tests pass we're likely safe to ship.

57d3fe9

@johnnyreilly johnnyreilly merged commit 6d8d601 into TypeStrong:master Oct 13, 2020
@johnnyreilly johnnyreilly mentioned this pull request Oct 14, 2020
Closed
@johnnyreilly johnnyreilly mentioned this pull request Nov 3, 2020
Closed
@allen-munsch allen-munsch mentioned this pull request Sep 9, 2021
Closed
@admmasters admmasters mentioned this pull request Nov 5, 2022
Open
@admmasters admmasters mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyreilly johnnyreilly johnnyreilly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpack 5: deprecation warning [DEP_WEBPACK_MODULE_ERRORS]
2 participants
@sanex3339 @johnnyreilly