Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update babel-loader docs for type-only modules watch #486

Merged
merged 2 commits into from
Jul 25, 2020

Conversation

piotr-oles
Copy link
Collaborator

This update should help with the babel-loader issues described in the #36 :)

@piotr-oles piotr-oles requested a review from johnnyreilly July 22, 2020 07:27
@piotr-oles piotr-oles self-assigned this Jul 22, 2020
@dmarkow
Copy link

dmarkow commented Jul 22, 2020

I'm using babel-typescript. This update says "If you use TypeScript >=3.8.0, you can fix it:" however I just tested these recommendations (setting onlyRemoveTypeImports to true) and updating a types-only file is still not triggering a build. I need to fully restart webpack to get it to recognize my updates.

@piotr-oles
Copy link
Collaborator Author

Thanks for the feedback. Is this file imported somehow by another file or is it just a reference / ambient context? This is not an ultimate solution, it should fix the same cases as "importsNotUsedAsValues": "preserve" which doesn't mean it will fix all cases. I'm thinking about a better solution but I don't have time to implement it.

@codeclimate
Copy link

codeclimate bot commented Jul 25, 2020

Code Climate has analyzed commit a91b08a and detected 0 issues on this pull request.

View more on Code Climate.

@johnnyreilly
Copy link
Member

Nice! 👍

@piotr-oles piotr-oles merged commit cf52452 into master Jul 25, 2020
@piotr-oles piotr-oles deleted the docs/update-babel-loader-docs branch July 25, 2020 09:46
@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 5.0.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants