Return updated items in resolve*
operations
#74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at least with latest monaco 0.12.0 the resolution of suggestion items is broken in some cases. it can be reproduced with JDT LS, when you continue typing a prefix of a suggestion shown after the suggestions were triggered explicitly. it happens that the
completion/resolve
params are missing adata
field.the actual issue is, that monaco looses information, because the
CompletionItemProvider
won't fill up the given item, but returns a new one, which is the converted result from LS.monaco's
SuggestAdapter
, which calls the completion item provider, will just update the given suggestion item and overwrites such additional fields, if they are not preserved by LSs.reading the docs and looking at other
CompletionItemProvider
implementations, shows that it's OK to return the given item, which can be updated with more data from LS response.the resolution of
CodeLense
s is also broken with JDT LS.