Skip to content

[TT-10393] RateLimiter#97

Open
mativm02 wants to merge 7 commits intomainfrom
TT-10393
Open

[TT-10393] RateLimiter#97
mativm02 wants to merge 7 commits intomainfrom
TT-10393

Conversation

@mativm02
Copy link
Contributor

@mativm02 mativm02 commented Dec 6, 2023

Description

Adding SetRollingWindow and GetRollingWindow to Redis V8 driver so we can have a rate limiter.

Related Issue

https://tyktech.atlassian.net/browse/TT-10393?atlOrigin=eyJpIjoiOTNmM2M4ZjIzMjRhNGIxOThiOTVlYmFlOTc5ZjQ4OWUiLCJwIjoiaiJ9

Motivation and Context

https://tyktech.atlassian.net/browse/TT-10393?atlOrigin=eyJpIjoiOTNmM2M4ZjIzMjRhNGIxOThiOTVlYmFlOTc5ZjQ4OWUiLCJwIjoiaiJ9

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • I have reviewed the guidelines for contributing to this repository.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...

@mativm02 mativm02 marked this pull request as ready for review December 7, 2023 13:07
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant