TT-448: add mservctl update command #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AaronFeledy Thank you for the effort, I will check this and get back to you as soon as possible. |
komuw
reviewed
Nov 30, 2022
mitjaziv
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
@AaronFeledy this looks great, thank you for you contribution and sorry it took so long.
mitjaziv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While mserv supports updating bundles, the mservctl client does not currently implement this functionality. This PR implements it by adding an
mservctl updatecommand to the tool.Usage:
mservctl update 9c9ecec1-8f98-4c3f-88cd-ca3c27599e6b bundle.zipRelated Issue
#15
Motivation and Context
Currently, mservctl only allows us to delete and recreate plugin entries each time we make a code update to one of our plugins. Our plugins are shared in multiple APIs and we promote them through dev->stage->prod environments. This creates a lot of work as each API needs to be updated with the new plugin ID in each environment following each new update to the plugin. The ability to update the existing plugin saves us from much of this work.
Types of changes