Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1913] Add CODEOWNERS, set up GitHub templates, and update docs #23

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

jlucktay
Copy link
Contributor

Description

  • configured CODEOWNERS file to fallback auto-assign PRs to the Architect team if no other assignee is set
  • added templates for GitHub issues and PRs
  • did a formatting pass on the README

Related Issue

TT-1913.

Motivation and Context

More automation means less toil for humans.

Test Coverage For This Change

N/A

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor in applicable directories.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@jlucktay jlucktay requested a review from a team March 22, 2021 15:28
Copy link
Member

@excieve excieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@excieve excieve merged commit 1832e32 into master Mar 22, 2021
@excieve excieve deleted the update/docs/github-templates-etc branch March 22, 2021 15:35
@jlucktay jlucktay changed the title Add CODEOWNERS, set up GitHub templates, and update docs [TT-1913] Add CODEOWNERS, set up GitHub templates, and update docs Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants