Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lute): fix signedTxns reconstruction #168

Merged
merged 2 commits into from
May 15, 2024
Merged

fix(lute): fix signedTxns reconstruction #168

merged 2 commits into from
May 15, 2024

Conversation

acfunk
Copy link
Contributor

@acfunk acfunk commented May 13, 2024

Description

There was a bug in the construction of signedTxns where it was expecting result to only contain txns that the wallet signed. Lute's response has the same length as the request, so shift() was not appropriate - a simple index on result will do.

Checklist

Please, make sure to comply with the checklist below before expecting review

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@drichar drichar changed the title fix signedTxns reconstruction fix(lute): fix signedTxns reconstruction May 15, 2024
@drichar drichar merged commit fd85530 into TxnLab:main May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants