fix(openai): apply SELECTION-array unwrap to submit-handler llmModel (follow-up to #39)#40
Conversation
…odel The submit handler at src/server/index.ts:477-482 reads `openaiModel` via `settings.get` and assigns to `llmModel` (stored as draft metadata). Same SELECTION-array bug as PR #39 fixed in callOpenAI: without unwrap, draft.llmModel would hold `["gpt-5.4-mini"]` instead of `"gpt-5.4-mini"`, which could break later RuleBundle parses. Add `.venv-chrome-auth` and `playwright/.auth` to .prettierignore — these are runtime artifacts from chrome-auth-test verification infrastructure. Gates: `npm run check` 4/4 PASS.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .prettierignore file to exclude diagnostic artifacts and TypeScript declaration files. Additionally, it modifies the llmModel retrieval logic in src/server/index.ts to correctly unwrap array-based model settings, ensuring consistency with other parts of the application and preventing metadata corruption in the draft bundle. I have no further feedback to provide.
…ler-unwrap fix(openai): apply SELECTION-array unwrap to submit-handler llmModel (follow-up to #39)
1 participant
Follow-up to PR #39. The submit handler at src/server/index.ts:477-482 also reads
openaiModelviasettings.getand stores it intodraft.llmModel. Same SELECTION-array bug as callOpenAI; without unwrap,draft.llmModelholds["gpt-5.4-mini"]instead of"gpt-5.4-mini". Also adds .venv-chrome-auth + playwright/.auth to .prettierignore. CI 4/4 PASS.🤖 Generated with Claude Code