Skip to content

fix(openai): drop reasoning_effort + verbosity to match probe(d) shape (Devvit 400 round 3) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ComBba merged 1 commit into from
May 13, 2026
Merged

fix(openai): drop reasoning_effort + verbosity to match probe(d) shape (Devvit 400 round 3) #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,19 @@ import prettier from 'eslint-config-prettier';

export default tseslint.config(
{
ignores: ['node_modules', 'dist', 'build', '.devvit', 'coverage', '**/*.d.ts'],
ignores: [
'node_modules',
'dist',
'build',
'.devvit',
'coverage',
'**/*.d.ts',
'.venv-chrome-auth',
'playwright/.auth',
'scripts/chrome-reddit-*.py',
'scripts/repro-*.mjs',
'scripts/test-*.mjs',
],
},
js.configs.recommended,
...tseslint.configs.recommended,
Expand Down
21 changes: 10 additions & 11 deletions src/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,19 +1320,18 @@ async function callOpenAI(
// 7-bit ASCII, still strictly valid JSON, and any compliant parser
// (including OpenAI's) decodes it back to the same Unicode characters.
const rawBody = JSON.stringify({
model, // gpt-5.4-mini (default) / gpt-5.4-nano / gpt-5.4 — see devvit.json openaiModel
model, // gpt-5.4-mini (default) / gpt-5.4-nano / gpt-5.4 -- see devvit.json openaiModel
response_format: { type: 'json_object' },
messages,
// Tuned for what this call is: a mechanical NL → strict-JSON translation.
// reasoning_effort: 'none' — no hidden reasoning needed; keeps it fast and stops the
// token budget being eaten by reasoning (gpt-5.4 family value;
// older models call this 'minimal'). Measured ~1.1-1.4s.
// verbosity: 'low' — terse JSON, no commentary.
// max_completion_tokens — a compiled rule + a clarification fit well under 600.
// (no `temperature` — the gpt-5.x family only accepts the default; max_tokens isn't
// supported on these models, use max_completion_tokens.)
reasoning_effort: 'none',
verbosity: 'low',
// reasoning_effort + verbosity dropped 2026-05-14: PR #32 (single message)
// and PR #33 (source ASCII) both still hit HTTP 400 from Devvit transit.
// Probe v3 isolated (d)/(e) individually but never tested all-3 features
// on a large body simultaneously. Removing them keeps the body on the
// narrowest known-good shape: probe(f) = 5610 B single user message,
// no extra features, returned 200 in production 3 times. response_format
// stays (model output JSON contract); max_completion_tokens stays (cost cap).
// (no `temperature` -- gpt-5.x family only accepts the default; max_tokens
// isn't supported on these models, use max_completion_tokens.)
Comment on lines +1326 to +1334
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since reasoning_effort and verbosity are being removed from the API call, the label for the openaiModel setting in devvit.json should be updated. It currently still refers to these parameters, which could be confusing for users.

File: devvit.json, line 21:

"label": "OpenAI model for rule compilation (reasoning_effort: none, verbosity: low)",

Consider updating it to something like:
"label": "OpenAI model for rule compilation"

max_completion_tokens: 600,
});
// ASCII-safe rewrite: any non-ASCII char (>= 0x80) → `\uXXXX` literal in
Expand Down