Skip to content

Registry-Based Integration Architecture for Providers, Gateways, and Models - #910

Merged
kevincodex1 merged 73 commits into
Twigpine:mainfrom
jatmn:cheeky-cooking-moon
May 2, 2026
Merged

kevincodex1 merged 73 commits into
Twigpine:mainfrom
jatmn:cheeky-cooking-moon

Conversation

@jatmn

@jatmn jatmn commented Apr 26, 2026 •

Copy link
Copy Markdown
Collaborator

Registry-Based Integration Architecture for Providers, Gateways, and Models

Closes #893

Summary

This PR implements the registry/descriptor integration architecture proposed in #893.

It changes OpenClaude from a mostly flat, overloaded "provider" model into a descriptor-backed system that separates:

  • vendors/providers, such as OpenAI, Anthropic, Google, Moonshot, DeepSeek, and Z.AI
  • gateways/runtimes, such as OpenRouter, Ollama, LM Studio, LiteLLM, Groq, Together, Bedrock, Vertex, and GitHub
  • model families and model metadata, such as Claude, GPT, Kimi, DeepSeek, Llama, and Qwen
  • Anthropic-compatible proxy routes, as a distinct future-facing integration type

The main intent is to make integration work additive, reviewable, and less conflict-prone. New vendor, gateway, and model work should now be routed through descriptors and the related documentation rather than through scattered provider switches.

Project Codename

Project codename: cheeky-cooking-moon

That name came from Kilo Code's generated project/plan name. It was weirdly memorable, so it stuck. The codename does not affect runtime behavior; it is just the planning label for this integration-architecture migration.

Executive Summary Excerpt

From plan/cheeky-cooking-moon.md:

OpenClaude currently overloads the word "provider" across several different concerns: vendor, gateway, model family, and Anthropic proxy.

That overload leaks into the codebase as duplicated switches, partially overlapping type systems, and routing behavior that is hard to extend safely.

This plan introduces a descriptor registry under src/integrations/ so that integration metadata lives in one place; runtime routing can remain transport-specific; /provider, --provider, model lookup, validation, discovery, and /usage read from the same source of truth; existing user config remains backward compatible; and future integrations can be added with additive descriptor files instead of scattered switch edits.

At a high level, this PR establishes:

  • a descriptor model for vendors, gateways, models, brands, catalogs, runtime metadata, usage metadata, and future Anthropic proxy support
  • registry-backed metadata and compatibility surfaces for legacy provider/profile behavior
  • descriptor-backed provider flags, provider discovery, provider validation, route metadata, runtime request shaping, and model catalog resolution
  • generated integration artifacts so contributor-authored descriptors stay additive while loader/UI/preset metadata remains synchronized
  • documentation under /docs explaining how future contributors should add integrations in the new architecture

!!! VERY IMPORTANT INTEGRATION WARNING !!!

!!! WARNING !!!

This PR changes the core framework for how vendors, gateways, and models are added to OpenClaude.

Do not add new integrations by copying the old pattern of editing provider switch statements across many shared files.

For new integration work, read the descriptor-era documentation under /docs first, especially:

  • docs/architecture/integrations.md
  • docs/integrations/overview.md
  • docs/integrations/glossary.md
  • docs/integrations/how-to/add-vendor.md
  • docs/integrations/how-to/add-gateway.md
  • docs/integrations/how-to/add-model.md
  • docs/integrations/how-to/add-anthropic-proxy.md
  • docs/integrations/how-to/add-usage-support.md
  • docs/integrations/reference-samples.md
  • docs/integrations/common-pitfalls.md

In the descriptor-era flow, adding a normal gateway should usually mean:

  1. Add src/integrations/gateways/<id>.ts.
  2. Add src/integrations/gateways/<id>.models.ts only when the catalog/discovery logic is large enough to deserve a companion file.
  3. Add descriptor preset metadata only if the gateway should appear in preset-driven /provider flows.
  4. Run bun run integrations:generate.
  5. Add or update focused tests.

New gateways should not normally require hand-editing:

  • src/integrations/index.ts
  • src/integrations/compatibility.ts
  • src/integrations/providerUiMetadata.ts
  • provider flag tables
  • provider profile tables
  • /provider UI switch logic
  • /model switch logic
  • /usage switch logic
  • OpenAI shim base-url conditionals

If a new gateway appears to require broad switch edits, please stop and check the docs before continuing. That is almost certainly a sign that the new descriptor path should be used instead.

What Changed

  • Added the descriptor/registry architecture under src/integrations/.
  • Added descriptor helpers so integration files can use defineVendor, defineGateway, defineModel, defineCatalog, and related helpers instead of directly mutating registry state.
  • Added generated integration artifacts and scripts so descriptor-authored metadata can feed loader, preset, and UI compatibility surfaces.
  • Moved provider flags, provider/profile compatibility, route metadata, provider discovery, provider validation, model metadata, and runtime request-shaping paths toward descriptor-backed data.
  • Added discovery/cache support for descriptor-backed model catalogs, including static, dynamic, and hybrid catalog patterns.
  • Preserved backward compatibility for existing provider profile and preset behavior while introducing the clearer vendor/gateway/model vocabulary.
  • Added docs for the new integration workflow and common pitfalls.

Backward Compatibility

This PR is intended to preserve existing user-facing behavior while changing the internal integration model.

Important compatibility goals:

  • existing saved provider profiles should continue to load
  • existing --provider values should continue to work
  • existing provider defaults and environment variable behavior should remain stable
  • current OpenAI-compatible routing should continue through the OpenAI shim
  • native Anthropic-style routes should remain native rather than being collapsed into OpenAI-compatible behavior
  • /usage should either resolve supported descriptor-backed usage behavior or show a clear unsupported-provider fallback

Documentation

The new docs are part of the migration, not optional follow-up polish.

Start here:

  • docs/architecture/integrations.md
  • docs/integrations/overview.md
  • docs/integrations/glossary.md

Then use the specific how-to guide for the integration type:

  • vendors: docs/integrations/how-to/add-vendor.md
  • gateways: docs/integrations/how-to/add-gateway.md
  • models: docs/integrations/how-to/add-model.md
  • Anthropic proxies: docs/integrations/how-to/add-anthropic-proxy.md
  • usage support: docs/integrations/how-to/add-usage-support.md

Reference examples and pre-PR review guidance:

  • docs/integrations/reference-samples.md
  • docs/integrations/common-pitfalls.md

Testing

Smoke/release checks run locally:

bun install
bun run build
bun run smoke

Observed smoke output:

0.6.0 (OpenClaude)

Build output confirmed:

Built openclaude v0.6.0 -> dist/cli.mjs

Reviewer Notes

This is a core architecture change. Please review with special attention to:

  • whether every current provider route still maps cleanly through descriptors or compatibility metadata
  • whether descriptor-backed route metadata preserves existing auth, base URL, model default, and startup behavior
  • whether gateway/direct-vendor catalogs avoid implying support for every shared model descriptor
  • whether github, bedrock, vertex, and other special routes still preserve their runtime expectations
  • whether OpenAI-compatible shim behavior remains transport-specific and does not regress reasoning/thinking edge cases
  • whether new docs make the future integration path obvious enough for contributors

Follow-Up Scope

This PR establishes the descriptor-era architecture and migration path. It does not need to solve every future UX refresh.

Reasonable follow-ups include:

  • revisiting /provider onboarding UX once descriptor metadata has stabilized
  • revisiting /model presentation and filtering once model metadata is richer
  • refreshing /usage presentation around descriptor-backed usage metadata
  • considering a future settings.json shape that more directly reflects vendor/gateway/model distinctions

jatmn added 30 commits April 25, 2026 12:22
- preserve GitHub, Bedrock, and Vertex runtime flags during profile activation\n- serialize descriptor-backed startup profiles into legacy-compatible persisted kinds\n- add regression coverage for activation, restart round-trip, and saved-profile switching\n- guard integration registration so repeated imports stay idempotent in tests
Complete the Phase 1E CLI/usage migration work and the Phase 1F verification pass for descriptor-backed providers.

Details:

- derive valid --provider values from descriptor registry and compatibility mappings instead of a fixed list

- preserve special CLI semantics for ollama and minimax while allowing descriptor-backed OpenAI-compatible routes such as deepseek and openrouter to pick up descriptor base URLs

- add getUsageDescriptor() so /usage resolves vendor/gateway metadata and follows usage delegation

- switch Settings Usage rendering to descriptor-backed usage resolution for Anthropic, MiniMax, and neutral unsupported fallbacks

- make integration loading idempotent via ensureIntegrationsLoaded() so registry-backed helpers survive tests that clear the registry

- fix compatibility mapping for mistral so the preset routes through vendorId=openai with gatewayId=mistral rather than a nonexistent direct vendor route

- harden provider profile and startup tests so descriptor-backed providers, legacy OpenAI startup files, and unknown stored providers round-trip correctly

- remove a stale ollama model mock that was leaking across the full model test suite

- update plan/progress.md with the current 1E complete / 1F in-progress verification state and the note that repo-wide typecheck failures are pre-existing outside this migration slice

Verification:

- bun test src/commands/usage/index.test.ts src/integrations/compatibility.test.ts src/utils/providerFlag.test.ts src/utils/providerProfiles.test.ts src/utils/providerProfile.test.ts src/utils/model/modelCache.test.ts src/integrations/index.test.ts src/integrations/registry.test.ts

- filtered bun run typecheck output for the files changed in this branch is clean
Fixes the follow-up review issues from the Phase 2A / 2A.5 work.

Completed work:

- made discovery cache stale entries reachable through getCachedModels(..., { includeStale: true }) while keeping fresh-by-default behavior unchanged

- kept recordDiscoveryError stale-data preservation useful to later /model consumers by exposing stale and error-only entries through the public helper API

- extended descriptor-backed validation routing metadata with host alias matching support

- updated MiniMax validation routing to recognize both api.minimax.io and api.minimax.chat endpoints

- added regression coverage for stale cache reads, error-only cache entries, and MiniMax chat-host validation

- updated progress.md notes so the recorded 2A.5 helper behavior matches the implementation
Implement descriptor-backed discovery and readiness routing for Phase 2B.

Highlights:

- add src/integrations/discoveryService.ts to execute declarative catalog.discovery configs with shared discovery-cache integration

- add hybrid merge behavior so curated descriptor catalog entries stay ahead of discovered duplicates

- add typed startup readiness metadata via ReadinessProbeKind and wire gateway descriptors for ollama, atomic-chat, lmstudio, and openrouter

- export probeOllamaModelCatalog() so discovery can distinguish unreachable Ollama from reachable-but-empty catalogs

- migrate ProviderManager and /provider flows to probeRouteReadiness() while preserving existing Ollama messaging

- route bootstrap local model discovery through descriptor-backed discovery for recognized local routes, while keeping legacy fallback for generic custom endpoints

- add resolveDiscoveryRouteIdFromBaseUrl() so bootstrap can share descriptor-backed discovery and local provider labels

- preserve explicit provider env precedence during applySavedProfileToCurrentSession() after focused verification exposed the regression

- update plan/progress.md to mark Phase 2B complete and record the verification notes

Verification:

- bun test src/integrations/discoveryService.test.ts

- bun test src/components/ProviderManager.test.tsx

- bun test src/commands/provider/provider.test.tsx

- bun test src/utils/providerDiscovery.test.ts src/integrations/registry.test.ts src/integrations/index.test.ts

- filtered bun run typecheck for the touched 2B files returned FILTER_CLEAN
Finish the Phase 2C runtime metadata adoption work on cheeky-cooking-moon.

Provider UI metadata:

- add shared route metadata and provider preset UI metadata helpers

- move preset labels/defaults, route type labels, and custom-header capability checks onto descriptor-backed lookups

- update ProviderManager and /provider summaries/setup copy to read shared descriptor metadata instead of bespoke switches

- extend local gateway descriptors with default model metadata used by the shared UI helpers

Model discovery UX:

- add route catalog option builders for descriptor-backed /model rendering

- update /model to resolve the active route, read cached route catalogs before rendering, and trigger background refresh when cached discovery is stale

- add /model refresh plus in-picker refresh via modelPicker:refresh and the r keybinding

- clear discovery cache on manual refresh and surface non-blocking loading/success/stale-error states in ModelPicker

- keep descriptor-backed dynamic and hybrid routes on the shared discovery cache service

Verification and hardening:

- fix combined test pollution by isolating /model test module imports and using real OpenRouter descriptor metadata during shared runs

- update progress.md to mark Phase 2C complete with verification notes

- verified with bun test for provider profiles, ProviderManager, /provider, /model, discovery cache, and provider validation suites
Align descriptor-backed runtime provider behavior with the legacy APIProvider surface so active routes, OpenAI shim behavior, and resume handling all resolve through the same metadata path.

Add runtimeMetadata.ts to centralize active route detection, OpenAI shim overrides, and native-format inference. Update provider resolution to map descriptor-backed routes onto legacy provider categories while preserving existing compatibility fallbacks for Foundry, NVIDIA NIM, MiniMax, GitHub, Bedrock, and Vertex.

Move request-shaping rules onto descriptor metadata for DeepSeek, Moonshot, Kimi Code, Gemini, Mistral, GitHub, and local gateways, including reasoning_content preservation, deepseek-compatible thinking payloads, max_tokens field selection, and store field stripping. Treat GitHub Claude native transport as Anthropic-native during conversation recovery so thinking blocks survive resume flows.

Extend focused tests for provider resolution, OpenAI shim request shaping, and conversation recovery, and update phase tracking notes in progress.md to mark 2D complete with verification details.
Complete the Phase 2E verification and drift-audit packet for the descriptor migration branch.

Add representative provider-summary coverage for descriptor-backed OpenRouter routing plus Gemini and Mistral current-provider summaries in src/commands/provider/provider.test.tsx. Extend ProviderManager coverage with first-run Atomic Chat discovery-backed setup and a regression test proving the set-active picker now uses descriptor-backed provider-type labels.

Replace stale saved-profile picker wording in ProviderManager so saved profiles no longer collapse to a coarse anthropic/openai-compatible split and instead render the route's descriptor-backed provider type label.

Add plan/phase-2e-drift-audit.md documenting the remaining intentional switch sites and non-switch provider branches across provider summaries, active-route detection, OpenAI shim env remapping, auth/header exceptions, and conversation recovery. Update plan/progress.md to mark Phase 2 and 2E complete on-branch, record focused verification, and note the follow-up hardening completed during audit review.

Verification completed during this packet: bun test src/components/ProviderManager.test.tsx src/commands/provider/provider.test.tsx src/utils/providerValidation.test.ts src/integrations/discoveryService.test.ts src/commands/model/model.test.tsx and bun test src/utils/providerDiscovery.test.ts src/utils/model/providers.test.ts src/services/api/openaiShim.test.ts src/utils/conversationRecovery.test.ts. Filtered typecheck output still shows pre-existing baseline noise in src/services/api/openaiShim.ts and src/utils/conversationRecovery.ts only.
Complete the skipped provider-surface follow-up discovered during the post-Phase-2 review.

- add focused status coverage for NVIDIA NIM and MiniMax sessions

- add Mistral entries to legacy teammate/model compatibility configs

- fill deprecation placeholders for the widened APIProvider surface

- add focused regression tests for status and teammate fallbacks

- update the Phase 2 drift audit and progress tracker with the compatibility-bridge notes and Phase 3 staging context
Begin the Phase 3 cleanup pass with the metadata-only dead-switch removals that are safe to land independently on cheeky-cooking-moon.

Completed work:

- updated plan/progress.md to move Phase 3 and Phase 3A into IN_PROGRESS, added slice-level checklists, and recorded what remains intentionally deferred to later packets

- removed duplicated OpenAI-compatible status-display branches in src/utils/status.tsx by routing openai/codex/nvidia-nim/minimax through shared metadata helpers

- replaced the pure transport-kind label switch in src/integrations/routeMetadata.ts with shared label metadata

- replaced the pure provider-label switch in src/components/CostThresholdDialog.tsx with a shared provider-label map

- added focused regression coverage in src/utils/status.test.ts, src/integrations/routeMetadata.test.ts, and src/components/CostThresholdDialog.test.ts

Verification:

- bun test src/utils/status.test.ts src/utils/swarm/teammateModel.test.ts src/utils/model/providers.test.ts

- bun test src/integrations/routeMetadata.test.ts src/utils/status.test.ts src/components/CostThresholdDialog.test.ts src/utils/model/providers.test.ts

- filtered bun run typecheck for the touched status/routeMetadata/CostThresholdDialog files returned FILTER_CLEAN
Complete the uncommitted Phase 3B compatibility rename work and the Phase 3C env-shaping consolidation on cheeky-cooking-moon.

Phase 3B:
- introduce LegacyAPIProvider while keeping APIProvider as the public compatibility alias
- introduce LegacyProviderModelConfig and LEGACY_PROVIDER_MODEL_CONFIGS while keeping ModelConfig and ALL_MODEL_CONFIGS as compatibility exports
- switch modelStrings, deprecation helpers, and provider profile compatibility naming onto the legacy/compatibility terminology

Phase 3C:
- add shared managed-env clear/apply helpers in providerProfile.ts and route buildLaunchEnv through the shared compatibility env shaper
- route applyProviderProfileToProcessEnv through the same compatibility env shaper so config-backed profiles and startup/session env construction stay aligned
- preserve explicit exception behavior for github, mistral, bedrock, vertex, bankr aliasing, MiniMax fallback detection, and NVIDIA NIM mode markers
- reduce createOpenAIShimClient to the remaining credential alias hydration that resolveProviderRequest does not already cover
- fix applySavedProfileToCurrentSession so saved-profile switching can move away from stale GitHub env selections
- add regression coverage for NVIDIA NIM env stamping and stale Codex-managed env clearing
- update progress.md to mark Phase 3B and 3C complete on branch and record the verification notes

Verification:
- bun test src/utils/model/providers.test.ts src/utils/providerProfiles.test.ts src/utils/swarm/teammateModel.test.ts src/utils/status.test.ts
- bun test src/utils/providerProfile.test.ts src/utils/providerProfiles.test.ts src/services/api/openaiShim.test.ts
- filtered bun run typecheck confirmed no new hits in providerProfile.ts or providerProfiles.ts; remaining openaiShim.ts hits are existing repo baseline debt
Complete the Phase 3D final audit/documentation packet on cheeky-cooking-moon.

Work completed:
- add plan/phase-3d-final-audit.md with the final post-Phase-3 inventory of remaining provider-specific runtime branches
- classify the remaining exceptions as intentional long-term runtime differences or temporary env/config compatibility bridges
- confirm the audit did not uncover new missed runtime migration work that requires additional Phase 3 code changes
- add docs/architecture/integrations.md to document the descriptor-first architecture, current constraints, known exceptions, and follow-on guidance for future cleanup
- update plan/progress.md to mark Phase 3D complete on branch, mark 3C merged on branch, and point the tracker at Phase 4A next

Key exception categories documented:
- github dual-mode transport behavior
- mistral dedicated route/runtime shaping
- bedrock/vertex/foundry native Anthropic-family paths
- Azure and Bankr request-auth/header differences
- Gemini, DeepSeek, and Moonshot/Kimi OpenAI-shim quirks
- MiniMax dedicated usage handling
- native web-search gating
- env-only MiniMax and NVIDIA NIM compatibility fallbacks
- env/config compatibility bridges such as route detection, --provider shaping, and startup/provider summaries

Notes:
- this packet is branch-local audit/documentation work only; no runtime code paths were changed
- no new tests were required for the audit/doc pass
Add the Phase 4 documentation/reference-samples plan to progress.md in the same packet/checkpoint structure as earlier phases, and reconcile the Phase 3 tracker summary with the completed cleanup state. Also fix applySavedProfileToCurrentSession so Codex saved-profile activation does not overwrite an already explicit live provider selection, while still clearing stale profile-managed markers when needed.
Expand the integrations architecture note with descriptor authoring, routing-contract, transport-boundary, and compatibility-layer guidance. Add overview and glossary docs under docs/integrations/, plus new how-to guides for adding vendors and gateways with one-file and two-file patterns, discovery cache guidance, token-field guidance, and compatibility follow-through. Update progress.md to mark Phase 4 in progress, Phase 4A complete, and Phase 4B complete with notes about the new docs structure and guide outputs.
Add the remaining descriptor contributor guides for models, anthropic proxies, and /usage support.

Add a reference sample pack and a common-pitfalls checklist, update the integrations overview, and reconcile plan/progress.md so Phase 4 is marked complete on cheeky-cooking-moon with the current implementation boundaries called out explicitly.
Update plan/progress.md to formally waive the remaining repo-wide typecheck item for Phase 1F as pre-existing debt outside the descriptor migration scope, and mark the Phase 4 branch-local checkpoints as landed on cheeky-cooking-moon with the corresponding commit references.
Update cheeky-cooking-moon with upstream/main while preserving the descriptor-backed provider framework.

Resolved conflicts in ProviderManager, openaiShim, providerFlag, and providerProfiles by keeping descriptor-driven preset/default/runtime behavior instead of reintroducing hardcoded provider branches.

Integrated upstream Z.AI support as a descriptor-backed vendor, including preset UI metadata, provider flag handling, profile defaults, runtime shim metadata, thinking support, and focused tests.

Adjusted OpenAI shim runtime metadata to infer descriptor routes from request base URLs so Z.AI URL-only shim calls get max_tokens, store stripping, and thinking controls.

Kept new upstream knowledge graph/conversation arc changes and cleaned trailing whitespace from those merged files.
Reviewed the upstream main merge against plan/cheeky-cooking-moon.md and removed drift from the old switch/helper-based Z.AI provider path.

Moved Z.AI reasoning, context-window, and max-output metadata into the descriptor route catalog so thinking support can read catalog capabilities instead of URL/model helper checks.

Removed the standalone src/utils/zaiProvider.ts helper and updated startup/provider-discovery labeling to resolve known direct routes through descriptor route metadata.

Simplified --provider handling for Z.AI by letting descriptor defaults provide the base URL and default model through the generic OpenAI-compatible provider branch.

Updated startup and provider-discovery tests for descriptor-backed labels, added Z.AI descriptor-label coverage, and documented the post-main-merge reconciliation in plan/progress.md.

Verification before commit: bun test src/utils/providerFlag.test.ts src/utils/providerProfiles.test.ts src/utils/thinking.test.ts src/components/StartupScreen.test.ts src/utils/providerDiscovery.test.ts; bun test src/integrations/compatibility.test.ts src/integrations/index.test.ts src/integrations/registry.test.ts src/services/api/openaiShim.test.ts; git diff --check.
Restore the descriptor-era Anthropic/OpenAI boundary during conversation recovery by threading the legacy provider category into usesAnthropicNativeMessageFormat instead of relying on ambient env-only route detection.

Harden branch-added provider-facing tests so they do not inherit leaked bun mock.module state from neighboring suites. Status, thinking, teammate fallback, and GitHub model options tests now restore mocks and/or import fresh modules under explicit provider context.

Update bugfix assertions to validate the descriptor-backed openaiShim contract for removeBodyFields/store stripping instead of the pre-refactor inline conditionals.

Validation:
- focused status/thinking/conversationRecovery/bugfix suites pass
- full bun test --max-concurrency=1 is down to the existing conversationArc perf benchmark failure only
- bun run smoke
- bun run build
- npm pack
Address the follow-up review against plan/cheeky-cooking-moon.md by fixing the remaining runtime drift and locking the behavior with focused coverage.

Completed work:

- make NVIDIA NIM descriptor-backed auth consistent across validation, --provider env shaping, and openaiShim request auth so NVIDIA_API_KEY works without requiring OPENAI_API_KEY

- resolve /usage from the active descriptor route instead of collapsing most OpenAI-compatible providers into the legacy openai bucket

- honor discoveryRefreshMode in /model so manual, on-open, background-if-stale, and startup catalogs no longer behave identically

- clarify docs/progress notes so the branch no longer overstates one-file additive onboarding while loader and preset/UI compatibility surfaces are still manual

Verification:

- bun test src/services/api/openaiShim.test.ts src/utils/providerValidation.test.ts src/utils/providerFlag.test.ts src/utils/model/providers.test.ts src/commands/usage/index.test.ts src/commands/model/model.test.tsx
Investigated the current descriptor onboarding flow and documented the remaining manual choke points in the loader, preset compatibility mapping, provider UI metadata, and handwritten preset typing.

Tighten cheeky-cooking-moon so additive onboarding is a hard requirement, add Phase 3E for descriptor-native onboarding closure, and update the progress tracker to reflect that follow-up work instead of treating the branch as fully complete.
Implement the Phase 3E generated-artifact workflow for integration onboarding.

- add integration artifact generation and check scripts

- generate loader inventory, preset manifest, and preset type from descriptors

- move preset participation onto descriptor preset metadata for preset-facing vendors and gateways

- derive compatibility and provider UI metadata from the generated manifest

- remove descriptor-level preset ordering and sort presets by description with standard alphanumeric ordering

- pin the custom preset to the bottom automatically in generated ordering

- add validation for duplicate preset ids and incomplete preset metadata

- add generator tests for representative gateway and direct-vendor onboarding

- refresh ProviderManager tests for generated preset ordering

- update architecture/how-to/reference docs and progress tracking for the new regeneration workflow
Honor route-specific auth env vars across descriptor-backed OpenAI-compatible routes by centralizing credential resolution and using it in validation, bootstrap, discovery, and the OpenAI shim.

Persist Anthropic startup fallbacks as native anthropic profiles and restore them correctly at startup so the legacy startup file stays aligned with the active provider.

Wire discoveryRefreshMode='startup' into startup and provider activation flows, with LM Studio as a live startup-refresh example, and add regression coverage for validation, startup env shaping, discovery refresh, and shim auth handling.
Keep the existing custom gateway preset pinned to the bottom while moving the Anthropic preset ahead of the description-sorted remainder.

Regenerate the integration preset manifest/order and extend the artifact generator coverage to lock in both ordering rules.

Validation: bun test src/integrations/artifactGenerator.test.ts src/components/ConsoleOAuthFlow.test.tsx; bun run build
@devNull-bootloader

Copy link
Copy Markdown
Contributor

Those were currently restricted in prior reviews. I dont think they should be blockers, but I think it would be good for fast follow pr to adjust those more robustly.

Got it, thanks for the clarification. I'll track these credential-mapping gaps as a fast-follow PR to add proper host-based routing for Moonshot (.cn), DeepSeek variants, and Azure custom resource URLs, which we can plan later. That shouldn't block this one.

@Vasanthdev2004

Copy link
Copy Markdown
Collaborator

Targeted re-review of current head f5c3bac.

Verdict: Needs changes, but the previous registry test-order blocker is fixed.

What I rechecked:

  • The exact order-isolation failure I previously called out:
bun test --max-concurrency=1 ./src/integrations/registry.test.ts ./src/integrations/index.test.ts ./src/integrations/compatibility.test.ts

Result on current head: 35 pass / 0 fail.

So from my side, the shared-registry test isolation issue is resolved.

Remaining blocker:

  • GitHub still reports this PR as conflicted / not mergeable (DIRTY). Please rebase or merge latest main and resolve conflicts before we treat it as merge-ready.

Given the size of this PR, I still want us to keep the review scope honest: this comment only clears my earlier registry-order blocker. It is not a fresh full review of the whole architecture diff after conflict resolution.

@kevincodex1

Copy link
Copy Markdown
Member

hello bro @jatmn please fix failing tests. we target to merge this before the week ends. will release new version probably on Monday

Restore the missing first-party Anthropic auth routing imports used by getAnthropicClient so OpenAI-compatible provider client creation no longer throws at runtime.

Keep GitHub provider resolution from inheriting OPENAI_API_FORMAT=responses so GitHub GPT-4 and gpt-5-mini models continue to use chat completions while Codex-flavored models still route to responses.

Reset OPENAI_API_FORMAT in the affected API provider tests to prevent environment leakage across serial Bun test runs.

Verified with: bun test --max-concurrency=1
@jatmn

jatmn commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator Author

@kevincodex1, please review.

@kevincodex1

Copy link
Copy Markdown
Member

sorry bro I just merged something. please rebase and fix conflict again.

Bring the branch current with upstream/main at 0f0fd26.

Resolve the OpenAI shim conflict by keeping the branch's descriptor-driven removeBodyFields handling while also applying upstream's Gemini-host store stripping for providerOverride requests.

Verified with: bun test --max-concurrency=1
@kevincodex1

Copy link
Copy Markdown
Member

Solid foundational refactor with clear architectural intent and strong contributor docs. Not yet a clean approve — there are six concrete items I'd ask for before merging, plus a hygiene ask about the diff itself.


Scope check

  • 72 commits, 169 files, +18,464 / −2,875 against merge-base
  • 71 new files under src/integrations/ (descriptors + registry + generator)
  • ~3,094 lines of new contributor docs (welcome — and necessary for this kind of system)
  • Branch is current with main (just merged); only one deletion (src/utils/zaiProvider.ts, cleanly absorbed into descriptors)

Architecture: what's good

  • Descriptor types in src/integrations/descriptors.ts are clean. Vendors / gateways / anthropic-proxies / brands / models all narrow into defineX() helpers.
  • scripts/generate-integrations-artifacts.ts produces a typed barrel (generated/integrationArtifacts.generated.ts) — and there's a --check mode plus a real-tree test (artifactGenerator.test.ts:46-48) that
    fails if descriptors drift from the generated file. CI runs bun test, so drift is caught. ✅
  • withDiscoveryCacheLock (discoveryCache.ts:34) is correct under JS single-threaded semantics — synchronous body before the first await is atomic.
  • The compatibility layer (compatibility.ts, profileResolver.ts) preserves legacy preset names.

Concerns

  1. Behavior changes in getAPIProvider() priority order aren't all flagged

Refactor at src/utils/model/providers.ts swaps a hardcoded if-chain for resolveActiveRouteIdFromEnv(). Several priority orders shifted:

  • NVIDIA_NIM: was top priority, now only checked in the openai/custom and anthropic/default branches. NVIDIA_NIM=1 + CLAUDE_CODE_USE_GEMINI=1 used to return 'nvidia-nim'; now returns 'gemini'.
  • CLAUDE_CODE_USE_FOUNDRY: was last priority, now extracted before resolveActiveRouteIdFromEnv — effectively highest.
  • MINIMAX_API_KEY: was checked before the OPENAI flag (presence check); now resolves through resolveEnvOnlyProviderRouteId which only fires when no CLAUDE_CODE_USE_* flag is set.

Some of these may be intentional cleanups — I suspect they are — but they should be called out in the PR description and have explicit precedence-conflict tests added (current providers.test.ts doesn't
cross-test NVIDIA_NIM with the other USE flags).

  1. Hardcoded fallback list in openaiShim.ts:1597-1600 is dead code

const shouldStripResponsesStore =
(shimConfig.removeBodyFields ?? []).includes('store') ||
['mistral', 'gemini', 'moonshot', 'deepseek', 'zai', 'kimi-code'].includes(
runtimeShimContext.routeId ?? '',
) || ...

I checked: every one of those six routes already declares removeBodyFields: ['store'] in its descriptor, so the hardcoded array is unreachable. Either delete it (preferred — point of the descriptor system) or
comment why it's there. Worth a sweep for similar leftovers.

  1. profileResolver.ts:38 hardcodes vendorId: 'openai' for any gateway

const gateway = getGateway(provider)
if (gateway) {
return { vendorId: 'openai', gatewayId: gateway.id, routeId: gateway.id }
}

That's wrong for native-protocol gateways (bedrock, vertex). Today consumers only read routeId from this, so it's not a live bug — but it's a latent footgun the next contributor will trip over. Either look up
the real vendor from the gateway descriptor, or make vendorId optional in ResolvedProfileRoute.

  1. CI has to run bun test --max-concurrency=1 permanently

The branch contains 12+ "test isolation" commits (test: harden fast mode test isolation, test: prevent discovery privacy mock bleed, test: pin conversation recovery provider mock, etc.). The fix is per-file
afterAll(_clearRegistryForTesting; ensureIntegrationsLoaded). That works, but the contract is invisible — the next test author who touches the registry has no way to know they need this dance.

Suggestion: a global setupTests.ts that resets all relevant state (registry, env, discovery cache) between files, or at minimum a comment block in src/integrations/index.ts documenting the contract.

  1. vendors/anthropic.ts:6-7 evaluates process.env at module load

defaultBaseUrl: process.env.ANTHROPIC_BASE_URL ?? 'https://api.anthropic.com',
defaultModel: process.env.ANTHROPIC_MODEL ?? 'claude-sonnet-4-6',

Frozen at import time. Anything that mutates ANTHROPIC_BASE_URL later (profile env application, tests) won't be reflected in the descriptor. The getProviderPresetUiMetadata path does honor live env via
preset.baseUrlEnvVars, so most callers are fine — but direct readers of descriptor.defaultBaseUrl get a stale value. Either drop the env fallback from the descriptor (let the preset metadata be the only env
source) or add a comment.

  1. ModelPicker.tsx is a 788-line full rewrite that converts compiled output → source

main:src/components/ModelPicker.tsx starts with import { c as _c } from "react-compiler-runtime" (React Compiler output). The PR replaces it with hand-written source. The convention in this repo is mixed (some
.tsx are compiled, some are source), so this isn't necessarily wrong — but the diff is effectively unreviewable at the line level. It hides regressions inside the bigger refactor.

Strong suggestion: split this file's conversion into its own PR with a clear "no behavior change, source-form rewrite" commit, OR keep it as compiled output and edit minimally for this PR. Mixing it into a
169-file architectural change makes the intent ambiguous.

  1. Minor: 'unknown-fallback' string sentinel

Sprinkled across routeMetadata.ts:473, providerProfiles.ts:529, providerProfiles.ts:1020. A discriminated union ({ kind: 'resolved' | 'unknown', ... }) or null return would be more type-safe than a magic
string. Cosmetic.

Diff hygiene

72 commits including planning docs, multiple "fix test isolation" attempts, and several "Merge upstream main" commits. Whatever merge strategy you use, please don't fast-forward — the history will be hard to
bisect later. Squash-merge with the PR description as the message, OR an interactive rebase preserving the Phase 1/2/3/4 boundaries.

Verdict

Request changes (gentle). The architecture is the right direction and the descriptors are well-designed. Items 1, 2, 3, and 6 are concrete cleanups; 4 and 5 are documentation/lint asks; 7 is cosmetic. None of
these are deep — most are an afternoon of work.

Please address all of this:

  • delete the dead hardcoded list in openaiShim
  • fix vendorId in profileResolver
  • add a precedence test or two for the new getAPIProvider
  • either split the ModelPicker.tsx conversion or revert it

Then this is ready.

jatmn added 2 commits April 30, 2026 08:37
Resolve generic OpenAI-compatible profiles by their known descriptor base URLs so saved MiniMax, xAI, NVIDIA NIM, OpenRouter, and DeepSeek profiles use the correct route catalogs instead of the generic OpenAI model list.

Fix MiniMax defaults and display handling so provider-specific model IDs are not rendered as Claude Opus defaults, add current MiniMax M2.7 options, and cover the regressions with focused route/model tests.

Also clean up descriptor follow-ups from review: remove the dead OpenAI shim store-strip fallback list, preserve gateway vendor IDs for Bedrock/Vertex/GitHub profile resolution, and keep the ModelPicker compiled-form changes in this PR.
Remove import-time ANTHROPIC_BASE_URL and ANTHROPIC_MODEL reads from the Anthropic descriptor so descriptor defaults stay static and live env handling remains in preset metadata.

Add getAPIProvider precedence coverage documenting that explicit Gemini/OpenAI flags beat env-only MiniMax API key inference.

Add a regression check to keep the removed openaiShim hardcoded descriptor route fallback list from returning.
@jatmn

jatmn commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the careful review. This was very helpful, especially given the size of the descriptor refactor and how much surface area it touches.

I have gone through the reported items and addressed the merge-blocking pieces:

  • Removed the dead hardcoded route fallback list from openaiShim. Store stripping now stays descriptor-driven through removeBodyFields.
  • Fixed profileResolver so gateway routes use the descriptor's real vendorId, which covers native gateways like Bedrock and Vertex correctly.
  • Added explicit getAPIProvider() precedence coverage, including the intentional behavior that explicit provider flags like Gemini/OpenAI take precedence over env-only MiniMax inference.
  • Removed import-time process.env reads from the Anthropic vendor descriptor so descriptor defaults remain static and live env handling stays in preset metadata.
  • Reworked the ModelPicker.tsx situation so it is no longer a large source-form rewrite mixed into this architectural PR. The current diff is limited to compiled-output style changes.
  • Added a regression check to keep the removed openaiShim fallback list from coming back.

I also ran the documented validation:

bun run build
bun run smoke

Both passed. Smoke output confirmed:

0.7.0 (OpenClaude)

A quick note on drift: since this PR was first opened, several other PRs have landed and the branch has had to absorb a fair amount of movement from main. I expect we will want to revisit a few PRs from the last several days after this framework lands, because some provider/runtime assumptions may no longer line up cleanly with the new descriptor-backed system.We will want to keep that follow-up focused and patch anything that no longer works against the new framework, rather than trying to fold more unrelated cleanup into this PR.

@gnanam1990 gnanam1990 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 1b743d6. Both blockers from my last pass are resolved.

Verified locally (cheeky-cooking-moon @ 1b743d6)

bun test --max-concurrency=1
→ 1921 pass, 0 fail across 201 files [8.31s]

The exact CI command now passes deterministically locally, where it previously failed with the registry-ordering issue.

What's resolved

  • ✅ src/integrations/registry.test.ts now has an afterAll that re-calls ensureIntegrationsLoaded() (17e6530) — restores the registry after the unit-test clears, so subsequent test files see a populated registry regardless of file-discovery order.
  • ✅ Provider-specific model routing fix (011d541) + the precedence regression test (1b743d6) cover the routing test failures cleanly.
  • ✅ plans/ directory removed (a6c4805, f5c3bac).
  • ✅ Main merged in cleanly twice; no fingerprint regressions on current head.

No openclaude red flags

  • No tengu_*, no USER_TYPE === 'ant', no new outbound network calls in 3P paths, no Anthropic fingerprints, no telemetry deps. Registry-based architecture is exactly the kind of refactor that makes the third-party path more maintainable.

This is a sizable change (18k+/2.5k-) but the test coverage is solid and the architecture splits cleanly along provider/gateway/model boundaries. LGTM 🚀

@Vasanthdev2004 Vasanthdev2004 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Targeted final re-review of current head 1b743d6 before squash merge.

Verdict: Approve-ready

What I checked:

  • The previous registry test-order blocker remains fixed. The deterministic order command now passes cleanly.
  • Kevin's requested cleanup items are addressed: descriptor-driven store stripping no longer has the dead route-name fallback list, gateway profile resolution now uses the descriptor vendor, provider precedence tests exist, and the Anthropic descriptor no longer depends on import-time env defaults.
  • Focused provider/auth/routing surfaces still keep provider-specific credentials scoped to their resolved routes.
  • CI is green on GitHub, and Gnanam's full bun test --max-concurrency=1 re-review also passed on this same head.

Verification run locally:

  • bun test --max-concurrency=1 ./src/integrations/registry.test.ts ./src/integrations/index.test.ts ./src/integrations/compatibility.test.ts passed 36/36
  • bun test src/utils/model/providers.test.ts src/services/api/openaiShim.test.ts src/utils/providerProfiles.test.ts passed 170/170
  • bun run build passed

Given the size/history of this PR, I still strongly recommend squash merge so main receives one clean architecture commit while the PR keeps the detailed discussion and review history.

`transportConfig.kind` is the first field to inspect.

## Vendor

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done another review on this and its looking great, I would just like if possible we remove the plan folder. I think its not needed anymore?

@kevincodex1
kevincodex1 merged commit b471745 into Twigpine:main May 2, 2026
2 checks passed
@techbrewboss
techbrewboss deleted the cheeky-cooking-moon branch May 2, 2026 00:36
dongjiang1989 added a commit to dongjiang1989/openclaude that referenced this pull request May 5, 2026
Replace the standalone sparkShim.ts and sparkModels.ts with a proper
vendor descriptor (src/integrations/vendors/spark.ts) that uses the
new registry-based integration architecture from PR Twigpine#910.

Changes:
- Add Spark vendor descriptor with OpenAI-compatible transport config
- Regenerate integration artifacts to include Spark preset
- Remove dedicated sparkShim.ts (now uses standard openaiShim routing)
- Remove sparkModels.ts (catalog lives in descriptor)
- Clean up scattered Spark references from validateModel, modelOptions,
  client.ts, and .env.example
- Update compatibility test to include spark preset

Fixes: sparkShim.ts non-streaming token counting bug where
response.clone() was called after response.json() had already consumed
the body stream.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The-FOOL-00 pushed a commit to The-FOOL-00/openclaude that referenced this pull request May 24, 2026
…Models (Twigpine#910)

* setting up

* updated plan with missing notes for discovery cache

* build out inital checklist and planning adjustments

* Phase 1A-1D

* Fix descriptor-backed provider profile routing

- preserve GitHub, Bedrock, and Vertex runtime flags during profile activation\n- serialize descriptor-backed startup profiles into legacy-compatible persisted kinds\n- add regression coverage for activation, restart round-trip, and saved-profile switching\n- guard integration registration so repeated imports stay idempotent in tests

* feat: finish phase 1 provider descriptor routing

Complete the Phase 1E CLI/usage migration work and the Phase 1F verification pass for descriptor-backed providers.

Details:

- derive valid --provider values from descriptor registry and compatibility mappings instead of a fixed list

- preserve special CLI semantics for ollama and minimax while allowing descriptor-backed OpenAI-compatible routes such as deepseek and openrouter to pick up descriptor base URLs

- add getUsageDescriptor() so /usage resolves vendor/gateway metadata and follows usage delegation

- switch Settings Usage rendering to descriptor-backed usage resolution for Anthropic, MiniMax, and neutral unsupported fallbacks

- make integration loading idempotent via ensureIntegrationsLoaded() so registry-backed helpers survive tests that clear the registry

- fix compatibility mapping for mistral so the preset routes through vendorId=openai with gatewayId=mistral rather than a nonexistent direct vendor route

- harden provider profile and startup tests so descriptor-backed providers, legacy OpenAI startup files, and unknown stored providers round-trip correctly

- remove a stale ollama model mock that was leaking across the full model test suite

- update plan/progress.md with the current 1E complete / 1F in-progress verification state and the note that repo-wide typecheck failures are pre-existing outside this migration slice

Verification:

- bun test src/commands/usage/index.test.ts src/integrations/compatibility.test.ts src/utils/providerFlag.test.ts src/utils/providerProfiles.test.ts src/utils/providerProfile.test.ts src/utils/model/modelCache.test.ts src/integrations/index.test.ts src/integrations/registry.test.ts

- filtered bun run typecheck output for the files changed in this branch is clean

* Phase 2 planning

* feat: complete phase 2A validation and discovery cache

* fix: address review findings for phase 2 cache and validation

Fixes the follow-up review issues from the Phase 2A / 2A.5 work.

Completed work:

- made discovery cache stale entries reachable through getCachedModels(..., { includeStale: true }) while keeping fresh-by-default behavior unchanged

- kept recordDiscoveryError stale-data preservation useful to later /model consumers by exposing stale and error-only entries through the public helper API

- extended descriptor-backed validation routing metadata with host alias matching support

- updated MiniMax validation routing to recognize both api.minimax.io and api.minimax.chat endpoints

- added regression coverage for stale cache reads, error-only cache entries, and MiniMax chat-host validation

- updated progress.md notes so the recorded 2A.5 helper behavior matches the implementation

* feat: complete phase 2B discovery and readiness migration

Implement descriptor-backed discovery and readiness routing for Phase 2B.

Highlights:

- add src/integrations/discoveryService.ts to execute declarative catalog.discovery configs with shared discovery-cache integration

- add hybrid merge behavior so curated descriptor catalog entries stay ahead of discovered duplicates

- add typed startup readiness metadata via ReadinessProbeKind and wire gateway descriptors for ollama, atomic-chat, lmstudio, and openrouter

- export probeOllamaModelCatalog() so discovery can distinguish unreachable Ollama from reachable-but-empty catalogs

- migrate ProviderManager and /provider flows to probeRouteReadiness() while preserving existing Ollama messaging

- route bootstrap local model discovery through descriptor-backed discovery for recognized local routes, while keeping legacy fallback for generic custom endpoints

- add resolveDiscoveryRouteIdFromBaseUrl() so bootstrap can share descriptor-backed discovery and local provider labels

- preserve explicit provider env precedence during applySavedProfileToCurrentSession() after focused verification exposed the regression

- update plan/progress.md to mark Phase 2B complete and record the verification notes

Verification:

- bun test src/integrations/discoveryService.test.ts

- bun test src/components/ProviderManager.test.tsx

- bun test src/commands/provider/provider.test.tsx

- bun test src/utils/providerDiscovery.test.ts src/integrations/registry.test.ts src/integrations/index.test.ts

- filtered bun run typecheck for the touched 2B files returned FILTER_CLEAN

* feat: complete phase 2c provider metadata migration

Finish the Phase 2C runtime metadata adoption work on cheeky-cooking-moon.

Provider UI metadata:

- add shared route metadata and provider preset UI metadata helpers

- move preset labels/defaults, route type labels, and custom-header capability checks onto descriptor-backed lookups

- update ProviderManager and /provider summaries/setup copy to read shared descriptor metadata instead of bespoke switches

- extend local gateway descriptors with default model metadata used by the shared UI helpers

Model discovery UX:

- add route catalog option builders for descriptor-backed /model rendering

- update /model to resolve the active route, read cached route catalogs before rendering, and trigger background refresh when cached discovery is stale

- add /model refresh plus in-picker refresh via modelPicker:refresh and the r keybinding

- clear discovery cache on manual refresh and surface non-blocking loading/success/stale-error states in ModelPicker

- keep descriptor-backed dynamic and hybrid routes on the shared discovery cache service

Verification and hardening:

- fix combined test pollution by isolating /model test module imports and using real OpenRouter descriptor metadata during shared runs

- update progress.md to mark Phase 2C complete with verification notes

- verified with bun test for provider profiles, ProviderManager, /provider, /model, discovery cache, and provider validation suites

* feat: complete phase 2d runtime provider alignment

Align descriptor-backed runtime provider behavior with the legacy APIProvider surface so active routes, OpenAI shim behavior, and resume handling all resolve through the same metadata path.

Add runtimeMetadata.ts to centralize active route detection, OpenAI shim overrides, and native-format inference. Update provider resolution to map descriptor-backed routes onto legacy provider categories while preserving existing compatibility fallbacks for Foundry, NVIDIA NIM, MiniMax, GitHub, Bedrock, and Vertex.

Move request-shaping rules onto descriptor metadata for DeepSeek, Moonshot, Kimi Code, Gemini, Mistral, GitHub, and local gateways, including reasoning_content preservation, deepseek-compatible thinking payloads, max_tokens field selection, and store field stripping. Treat GitHub Claude native transport as Anthropic-native during conversation recovery so thinking blocks survive resume flows.

Extend focused tests for provider resolution, OpenAI shim request shaping, and conversation recovery, and update phase tracking notes in progress.md to mark 2D complete with verification details.

* feat: complete phase 2e drift audit

Complete the Phase 2E verification and drift-audit packet for the descriptor migration branch.

Add representative provider-summary coverage for descriptor-backed OpenRouter routing plus Gemini and Mistral current-provider summaries in src/commands/provider/provider.test.tsx. Extend ProviderManager coverage with first-run Atomic Chat discovery-backed setup and a regression test proving the set-active picker now uses descriptor-backed provider-type labels.

Replace stale saved-profile picker wording in ProviderManager so saved profiles no longer collapse to a coarse anthropic/openai-compatible split and instead render the route's descriptor-backed provider type label.

Add plan/phase-2e-drift-audit.md documenting the remaining intentional switch sites and non-switch provider branches across provider summaries, active-route detection, OpenAI shim env remapping, auth/header exceptions, and conversation recovery. Update plan/progress.md to mark Phase 2 and 2E complete on-branch, record focused verification, and note the follow-up hardening completed during audit review.

Verification completed during this packet: bun test src/components/ProviderManager.test.tsx src/commands/provider/provider.test.tsx src/utils/providerValidation.test.ts src/integrations/discoveryService.test.ts src/commands/model/model.test.tsx and bun test src/utils/providerDiscovery.test.ts src/utils/model/providers.test.ts src/services/api/openaiShim.test.ts src/utils/conversationRecovery.test.ts. Filtered typecheck output still shows pre-existing baseline noise in src/services/api/openaiShim.ts and src/utils/conversationRecovery.ts only.

* fix: close phase 2 provider parity follow-through

Complete the skipped provider-surface follow-up discovered during the post-Phase-2 review.

- add focused status coverage for NVIDIA NIM and MiniMax sessions

- add Mistral entries to legacy teammate/model compatibility configs

- fill deprecation placeholders for the widened APIProvider surface

- add focused regression tests for status and teammate fallbacks

- update the Phase 2 drift audit and progress tracker with the compatibility-bridge notes and Phase 3 staging context

* phase 3 planning

* refactor: start phase 3a dead-switch cleanup

Begin the Phase 3 cleanup pass with the metadata-only dead-switch removals that are safe to land independently on cheeky-cooking-moon.

Completed work:

- updated plan/progress.md to move Phase 3 and Phase 3A into IN_PROGRESS, added slice-level checklists, and recorded what remains intentionally deferred to later packets

- removed duplicated OpenAI-compatible status-display branches in src/utils/status.tsx by routing openai/codex/nvidia-nim/minimax through shared metadata helpers

- replaced the pure transport-kind label switch in src/integrations/routeMetadata.ts with shared label metadata

- replaced the pure provider-label switch in src/components/CostThresholdDialog.tsx with a shared provider-label map

- added focused regression coverage in src/utils/status.test.ts, src/integrations/routeMetadata.test.ts, and src/components/CostThresholdDialog.test.ts

Verification:

- bun test src/utils/status.test.ts src/utils/swarm/teammateModel.test.ts src/utils/model/providers.test.ts

- bun test src/integrations/routeMetadata.test.ts src/utils/status.test.ts src/components/CostThresholdDialog.test.ts src/utils/model/providers.test.ts

- filtered bun run typecheck for the touched status/routeMetadata/CostThresholdDialog files returned FILTER_CLEAN

* refactor: complete phase 3b and 3c cleanup

Complete the uncommitted Phase 3B compatibility rename work and the Phase 3C env-shaping consolidation on cheeky-cooking-moon.

Phase 3B:
- introduce LegacyAPIProvider while keeping APIProvider as the public compatibility alias
- introduce LegacyProviderModelConfig and LEGACY_PROVIDER_MODEL_CONFIGS while keeping ModelConfig and ALL_MODEL_CONFIGS as compatibility exports
- switch modelStrings, deprecation helpers, and provider profile compatibility naming onto the legacy/compatibility terminology

Phase 3C:
- add shared managed-env clear/apply helpers in providerProfile.ts and route buildLaunchEnv through the shared compatibility env shaper
- route applyProviderProfileToProcessEnv through the same compatibility env shaper so config-backed profiles and startup/session env construction stay aligned
- preserve explicit exception behavior for github, mistral, bedrock, vertex, bankr aliasing, MiniMax fallback detection, and NVIDIA NIM mode markers
- reduce createOpenAIShimClient to the remaining credential alias hydration that resolveProviderRequest does not already cover
- fix applySavedProfileToCurrentSession so saved-profile switching can move away from stale GitHub env selections
- add regression coverage for NVIDIA NIM env stamping and stale Codex-managed env clearing
- update progress.md to mark Phase 3B and 3C complete on branch and record the verification notes

Verification:
- bun test src/utils/model/providers.test.ts src/utils/providerProfiles.test.ts src/utils/swarm/teammateModel.test.ts src/utils/status.test.ts
- bun test src/utils/providerProfile.test.ts src/utils/providerProfiles.test.ts src/services/api/openaiShim.test.ts
- filtered bun run typecheck confirmed no new hits in providerProfile.ts or providerProfiles.ts; remaining openaiShim.ts hits are existing repo baseline debt

* docs: complete phase 3d audit and architecture note

Complete the Phase 3D final audit/documentation packet on cheeky-cooking-moon.

Work completed:
- add plan/phase-3d-final-audit.md with the final post-Phase-3 inventory of remaining provider-specific runtime branches
- classify the remaining exceptions as intentional long-term runtime differences or temporary env/config compatibility bridges
- confirm the audit did not uncover new missed runtime migration work that requires additional Phase 3 code changes
- add docs/architecture/integrations.md to document the descriptor-first architecture, current constraints, known exceptions, and follow-on guidance for future cleanup
- update plan/progress.md to mark Phase 3D complete on branch, mark 3C merged on branch, and point the tracker at Phase 4A next

Key exception categories documented:
- github dual-mode transport behavior
- mistral dedicated route/runtime shaping
- bedrock/vertex/foundry native Anthropic-family paths
- Azure and Bankr request-auth/header differences
- Gemini, DeepSeek, and Moonshot/Kimi OpenAI-shim quirks
- MiniMax dedicated usage handling
- native web-search gating
- env-only MiniMax and NVIDIA NIM compatibility fallbacks
- env/config compatibility bridges such as route detection, --provider shaping, and startup/provider summaries

Notes:
- this packet is branch-local audit/documentation work only; no runtime code paths were changed
- no new tests were required for the audit/doc pass

* docs: stage phase 4 tracker and codex profile guard

Add the Phase 4 documentation/reference-samples plan to progress.md in the same packet/checkpoint structure as earlier phases, and reconcile the Phase 3 tracker summary with the completed cleanup state. Also fix applySavedProfileToCurrentSession so Codex saved-profile activation does not overwrite an already explicit live provider selection, while still clearing stale profile-managed markers when needed.

* docs: complete phase 4a and 4b guides

Expand the integrations architecture note with descriptor authoring, routing-contract, transport-boundary, and compatibility-layer guidance. Add overview and glossary docs under docs/integrations/, plus new how-to guides for adding vendors and gateways with one-file and two-file patterns, discovery cache guidance, token-field guidance, and compatibility follow-through. Update progress.md to mark Phase 4 in progress, Phase 4A complete, and Phase 4B complete with notes about the new docs structure and guide outputs.

* docs: complete phase 4 integration docs

Add the remaining descriptor contributor guides for models, anthropic proxies, and /usage support.

Add a reference sample pack and a common-pitfalls checklist, update the integrations overview, and reconcile plan/progress.md so Phase 4 is marked complete on cheeky-cooking-moon with the current implementation boundaries called out explicitly.

* docs: reconcile tracker waivers and checkpoints

Update plan/progress.md to formally waive the remaining repo-wide typecheck item for Phase 1F as pre-existing debt outside the descriptor migration scope, and mark the Phase 4 branch-local checkpoints as landed on cheeky-cooking-moon with the corresponding commit references.

* Align Z.AI merge fallout with descriptors

Reviewed the upstream main merge against plan/cheeky-cooking-moon.md and removed drift from the old switch/helper-based Z.AI provider path.

Moved Z.AI reasoning, context-window, and max-output metadata into the descriptor route catalog so thinking support can read catalog capabilities instead of URL/model helper checks.

Removed the standalone src/utils/zaiProvider.ts helper and updated startup/provider-discovery labeling to resolve known direct routes through descriptor route metadata.

Simplified --provider handling for Z.AI by letting descriptor defaults provide the base URL and default model through the generic OpenAI-compatible provider branch.

Updated startup and provider-discovery tests for descriptor-backed labels, added Z.AI descriptor-label coverage, and documented the post-main-merge reconciliation in plan/progress.md.

Verification before commit: bun test src/utils/providerFlag.test.ts src/utils/providerProfiles.test.ts src/utils/thinking.test.ts src/components/StartupScreen.test.ts src/utils/providerDiscovery.test.ts; bun test src/integrations/compatibility.test.ts src/integrations/index.test.ts src/integrations/registry.test.ts src/services/api/openaiShim.test.ts; git diff --check.

* fix: restore descriptor migration behavior and isolate provider tests

Restore the descriptor-era Anthropic/OpenAI boundary during conversation recovery by threading the legacy provider category into usesAnthropicNativeMessageFormat instead of relying on ambient env-only route detection.

Harden branch-added provider-facing tests so they do not inherit leaked bun mock.module state from neighboring suites. Status, thinking, teammate fallback, and GitHub model options tests now restore mocks and/or import fresh modules under explicit provider context.

Update bugfix assertions to validate the descriptor-backed openaiShim contract for removeBodyFields/store stripping instead of the pre-refactor inline conditionals.

Validation:
- focused status/thinking/conversationRecovery/bugfix suites pass
- full bun test --max-concurrency=1 is down to the existing conversationArc perf benchmark failure only
- bun run smoke
- bun run build
- npm pack

* fix: close descriptor review drift and provider regressions

Address the follow-up review against plan/cheeky-cooking-moon.md by fixing the remaining runtime drift and locking the behavior with focused coverage.

Completed work:

- make NVIDIA NIM descriptor-backed auth consistent across validation, --provider env shaping, and openaiShim request auth so NVIDIA_API_KEY works without requiring OPENAI_API_KEY

- resolve /usage from the active descriptor route instead of collapsing most OpenAI-compatible providers into the legacy openai bucket

- honor discoveryRefreshMode in /model so manual, on-open, background-if-stale, and startup catalogs no longer behave identically

- clarify docs/progress notes so the branch no longer overstates one-file additive onboarding while loader and preset/UI compatibility surfaces are still manual

Verification:

- bun test src/services/api/openaiShim.test.ts src/utils/providerValidation.test.ts src/utils/providerFlag.test.ts src/utils/model/providers.test.ts src/commands/usage/index.test.ts src/commands/model/model.test.tsx

* docs(plan): require descriptor-native gateway onboarding closure

Investigated the current descriptor onboarding flow and documented the remaining manual choke points in the loader, preset compatibility mapping, provider UI metadata, and handwritten preset typing.

Tighten cheeky-cooking-moon so additive onboarding is a hard requirement, add Phase 3E for descriptor-native onboarding closure, and update the progress tracker to reflect that follow-up work instead of treating the branch as fully complete.

* feat(integrations): close descriptor-native onboarding

Implement the Phase 3E generated-artifact workflow for integration onboarding.

- add integration artifact generation and check scripts

- generate loader inventory, preset manifest, and preset type from descriptors

- move preset participation onto descriptor preset metadata for preset-facing vendors and gateways

- derive compatibility and provider UI metadata from the generated manifest

- remove descriptor-level preset ordering and sort presets by description with standard alphanumeric ordering

- pin the custom preset to the bottom automatically in generated ordering

- add validation for duplicate preset ids and incomplete preset metadata

- add generator tests for representative gateway and direct-vendor onboarding

- refresh ProviderManager tests for generated preset ordering

- update architecture/how-to/reference docs and progress tracking for the new regeneration workflow

* Fix provider profile and discovery drift

Honor route-specific auth env vars across descriptor-backed OpenAI-compatible routes by centralizing credential resolution and using it in validation, bootstrap, discovery, and the OpenAI shim.

Persist Anthropic startup fallbacks as native anthropic profiles and restore them correctly at startup so the legacy startup file stays aligned with the active provider.

Wire discoveryRefreshMode='startup' into startup and provider activation flows, with LM Studio as a live startup-refresh example, and add regression coverage for validation, startup env shaping, discovery refresh, and shim auth handling.

* Pin Anthropic provider preset to the top

Keep the existing custom gateway preset pinned to the bottom while moving the Anthropic preset ahead of the description-sorted remainder.

Regenerate the integration preset manifest/order and extend the artifact generator coverage to lock in both ordering rules.

Validation: bun test src/integrations/artifactGenerator.test.ts src/components/ConsoleOAuthFlow.test.tsx; bun run build

* docs: refresh integration and setup guides

Update the new descriptor-era integration docs so they read as current contributor guidance instead of rollout notes, and align the authoring examples with the actual runtime metadata flow.

Highlights:

- add a CONTRIBUTING.md pointer to the integration overview and focused how-to guides

- remove branch/phase-specific wording from the integration docs

- fix OpenAI-compatible header guidance to use transportConfig.openaiShim headers and custom-header flags

- clarify anthropic proxy onboarding around generated loader support

- refresh advanced setup with current Codex, Gemini, Mistral, and profile-launch details

- fix LiteLLM /provider instructions and clarify local no-auth behavior

- tighten quick-start and non-technical cross-links so users can find the advanced provider docs

* fix: close descriptor integration drift

Apply descriptor-backed static headers to OpenAI-compatible request execution and model discovery, preserving request-specific header precedence.

Allow Gemini profile launch with API key, access-token, or ADC credentials, and align Gemini fallback defaults with the descriptor/docs default model.

Add regression coverage for descriptor header propagation, Gemini defaults, and discovery auth/header behavior.

* post-phase follow-up task added

* Fix xAI merge follow-ups

Route env-only XAI_API_KEY sessions through the OpenAI-compatible shim using descriptor-backed xAI defaults, and map the xAI key into OPENAI_API_KEY for shim auth.

Hydrate legacy profile: xai startup env with xAI descriptor defaults, preserving XAI_API_KEY and OpenAI-compatible launch behavior.

Update progress tracking for post-merge xAI descriptor inventory and clarify that profile-owned custom headers remain open despite adjacent auth/static-header plumbing.

Add regression coverage for env-only xAI client routing, legacy xAI launch env, shell key precedence, and the Gemini/OpenAI client test isolation issue.

* Complete profile custom headers follow-up

Add persisted provider-profile customHeaders support with shared parsing and sanitization for compact Name: value input. Reject malformed and reserved auth/internal headers before saving or applying profile-owned headers.

Expose a descriptor-gated /provider custom headers step, preserve headers during profile edit/update, and apply supported profile headers through ANTHROPIC_CUSTOM_HEADERS for active env and startup fallback profiles.

Propagate profile headers into descriptor discovery refresh and bootstrap model discovery while preserving descriptor/profile/auth merge order. Add focused regression coverage and mark the progress tracker packet complete.

* Allow api-key custom provider headers

Permit api-key in /provider custom header input and preserve it when OpenAI-compatible shim requests are built. This is intentional for gateway providers that require an api-key header in addition to, or instead of, standard bearer auth.

Keep managed credential headers protected by continuing to reject/strip authorization and x-api-key, plus Anthropic/Claude-owned headers. Add parser, profile env, and outgoing request coverage for the intended behavior.

* fix: restore API mode picker for OpenAI-compatible profiles

Use descriptor transport metadata instead of the legacy provider id when deciding whether provider profiles support OpenAI-compatible options. This restores the Chat Completions vs Responses picker for the Custom OpenAI-compatible preset after it moved to the descriptor-backed custom route.

Preserve apiFormat and custom auth header profile fields for all routes whose transportConfig.kind is openai-compatible, so selecting Responses is saved and applied as OPENAI_API_FORMAT=responses.

Tests: bun test src/components/ProviderManager.test.tsx; bun test src/utils/providerProfiles.test.ts; bun run build; bun run smoke

* fix: respect explicit provider routing with xAI env

Ensure env-only XAI_API_KEY fallback does not take over when Bedrock, Vertex, or Foundry has been explicitly selected. This preserves native transport routing while still allowing bare xAI env setup to use the OpenAI-compatible shim.

Restore api-key to the managed custom-header blocklist now that /provider exposes the API mode/auth-header controls for OpenAI-compatible profiles. The shim and provider override paths strip api-key again, while OPENAI_AUTH_HEADER=api-key remains available for explicit auth configuration.

Tests: bun test src/services/api/client.test.ts src/utils/providerCustomHeaders.test.ts src/utils/providerProfiles.test.ts src/services/api/openaiShim.test.ts; bun run build; bun run integrations:check; bun run smoke

* docs: fix integration drift

Align integration and setup docs with the current implementation.

- show model descriptor examples as array default exports, matching the generated MODEL_DESCRIPTOR_GROUPS loader contract

- document provider-scoped model env vars instead of implying OPENAI_MODEL globally overrides ANTHROPIC_MODEL

- clarify generated provider preset ordering: anthropic first, custom last, description-sorted middle entries

- update LiteLLM examples and /provider guidance to use the /v1 OpenAI-compatible base URL

Verification: bun run integrations:check

* Fix provider discovery cache isolation

* Stabilize provider env tests

* Stabilize provider test isolation

Completed work:

- Isolated GitHub model option tests from cached availableModels settings.

- Isolated startup discovery tests from live process.env provider flag races.

- Mocked teammate provider fallback tests at the provider helper boundary.

- Moved cost threshold provider labels into a pure helper for deterministic tests while preserving runtime active-provider behavior.

Validation:

- bun test src/components/CostThresholdDialog.test.ts src/integrations/discoveryService.test.ts src/utils/model src/utils/swarm

- bun run build

- bun run smoke

* test: isolate startup screen model settings

Clear the session settings cache and persisted global model around StartupScreen provider-detection tests.

This prevents earlier provider/model suites from leaking saved non-Anthropic models into the default Anthropic startup assertions.

Verified with: bun test src/components/StartupScreen.test.ts src/integrations/discoveryService.test.ts src/utils/model/modelOptions.github.test.ts

Full bun test now only fails the unrelated Conversation Arc sub-millisecond performance benchmark.

* test: isolate route discovery and github model options

Restore Bun module mocks around discoveryService tests before loading fresh route-discovery modules.

Pin the GitHub model-options test to a complete providers.js mock so cached provider mocks from other suites cannot hide Copilot options.

Verified with: bun test src/integrations/discoveryService.test.ts src/utils/model/modelOptions.github.test.ts

Also ran full bun test; only the unrelated Conversation Arc sub-millisecond performance benchmark fails locally.

* test: avoid startup discovery cache collision

Use the 127.0.0.1 LM Studio alias in refreshStartupDiscoveryForActiveRoute so it still resolves the active route from env but does not share the cache partition with the preceding startup refresh test.

This keeps the assertion on network refresh stable under Bun 1.3.11 serialized runs.

Verified with: bun test --max-concurrency=1 src/integrations/discoveryService.test.ts src/utils/model/modelOptions.github.test.ts

Also ran full bun test --max-concurrency=1; only the unrelated Conversation Arc perf benchmark fails locally.

* fix: isolate OpenAI-compatible route credentials

Restrict OpenAI-compatible shim auth to provider overrides, resolved route credentials, or explicit OPENAI_API_KEY instead of ambient provider-specific secrets.

Remove NVIDIA and Bankr compatibility fallbacks that could promote provider-specific API keys into unrelated OpenAI-compatible routes. Preserve Bankr base URL/model compatibility before route credential resolution so Bankr still resolves through descriptor credentials.

Clear stale NVIDIA_NIM and copied OPENAI_API_KEY values when switching away from NVIDIA NIM, Bankr, or xAI provider flags to avoid carrying provider secrets across route boundaries.

Add regressions for stale NVIDIA, MiniMax, and Bankr keys not leaking into OpenRouter-style routes, plus provider-flag cleanup for copied NVIDIA/Bankr/xAI keys.

Validation: bun test src/services/api/openaiShim.test.ts; bun test src/utils/providerFlag.test.ts; bun run build; bun run smoke.

* fix: guard model discovery privacy paths

Suppress descriptor and legacy model discovery while essential-only traffic mode is active.

Use the partitioned discovery cache key for /model cache reads, stale checks, and manual refresh clears, including route-specific credentials and custom headers.

Partition legacy local OpenAI additional model caches by credentials and routing headers to avoid catalog reuse across profiles.

Add coverage for OpenRouter route credentials, descriptor privacy suppression, legacy discovery privacy suppression, and local cache scope partitioning.

* Fix artifact checks and knowledge graph persistence

Normalize generated integration artifact comparisons so Windows line endings do not make checked-in artifacts appear stale.

Skip knowledge graph entity persistence when re-adding an existing entity with identical attributes, avoiding repeated disk writes during automatic fact extraction and restoring the conversation arc performance benchmark.

Verified with bun test src/integrations/artifactGenerator.test.ts --max-concurrency=1, bun test src/utils/conversationArc.perf.test.ts --max-concurrency=1, and bun test --max-concurrency=1.

* test: isolate privacy discovery cache path

The descriptor discovery privacy test could observe stale OpenRouter cache data populated by an earlier test and receive source=stale-cache instead of static. Use a test-specific API key so the privacy assertion gets its own discovery cache partition while still verifying that nonessential traffic disables network discovery.

Verified with bun test src/integrations/discoveryService.test.ts --max-concurrency=1 and bun test --max-concurrency=1.

* test: accept cached privacy discovery result

* test: set privacy gate before discovery import

* test: prevent discovery privacy mock bleed

Guard descriptor model discovery directly on CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC so nonessential traffic stays disabled even if the privacyLevel module is mocked in-process.

Reduce broad fastMode test mocks for shared modules and use real state/config test hooks, preventing Bun module mock namespaces from leaking into discovery and /model tests.

Verified with bun test src/utils/fastMode.test.ts src/utils/model/openaiModelDiscovery.test.ts src/integrations/discoveryService.test.ts src/commands/model/model.test.tsx --max-concurrency=1 and bun test --max-concurrency=1.

* test: prevent discovery privacy mock bleed

Add an env-level fallback guard to descriptor model discovery so disabled nonessential traffic cannot be bypassed by stale mocked privacy helpers.

Tighten the fastMode regression tests by setting real bootstrap/config state only after the tested module is imported, avoiding broad module mocks that can leak into unrelated discovery tests or behave differently under Bun in CI.

Verified with focused discovery/fastMode/model suites and the full serial bun test suite.

* fix: harden fast mode test isolation

Ignore non-string GrowthBook values when resolving the fast mode unavailable reason so boolean flag payloads cannot surface as false.

Make the affected regression tests install explicit provider mocks for their own scenarios and reset env state, preventing stale provider mocks from changing fastMode and conversation recovery behavior across the serial Bun test run.

* test: harden fast mode module mocks

Expand the fastMode GrowthBook and provider test mocks so later imports in the same Bun test process can resolve the named exports they expect. This prevents order-sensitive failures when model command tests run after fast mode tests.\n\nVerified with: bun test --max-concurrency=1

* feat: consolidate integration runtime metadata

Move OpenAI-compatible model runtime limits into descriptor-backed brand and model metadata, adding Gemini, GLM, MiniMax, Mistral, Nemotron, xAI, and OpenAI-compatible alias descriptor groups. Update generated integration artifacts, route catalog option handling, thinking capability lookup, and docs to use modelDescriptorId-backed runtime metadata.

Split OpenAI shim capability flags into supportsApiFormatSelection and supportsAuthHeaders, and update provider profile sanitization, ProviderManager forms, descriptor validation, and integration authoring docs so fixed routes do not preserve unsupported API format or auth-header settings.

Harden env-only MiniMax and xAI routing. Resolve shared route intent before client setup, reject conflicting OpenAI base URLs, preserve provider-specific base overrides, sanitize stale OpenAI shim knobs, copy provider credentials intentionally, and keep legacy provider labels, context windows, max output limits, model lists, and provider switching aligned.

Refresh MiniMax defaults and catalog entries, add descriptor-backed runtime limits for migrated models, preserve external OpenAI limit overrides, and add regression coverage for env-only MiniMax/xAI, provider-profile capability stripping, route catalog options, copied credential cleanup, and context/runtime limit detection.

Verification performed: bun test src/utils/providerFlag.test.ts; bun test src/services/api/client.test.ts src/utils/model/providers.test.ts src/integrations/routeMetadata.test.ts; bun test src/utils/context.test.ts src/utils/thinking.test.ts src/services/compact/autoCompact.test.ts; bun test src/integrations/routeMetadata.test.ts src/services/api/client.test.ts src/utils/model/providers.test.ts src/utils/providerValidation.test.ts src/integrations/index.test.ts src/utils/status.test.ts; bun run build; bun run smoke.

* test: isolate provider env in conversation recovery

Snapshot and restore all provider-selection environment variables used by the GitHub native Claude resume test instead of only restoring the GitHub flag and OPENAI_MODEL.

The full single-concurrency suite exposed that earlier tests can leave higher-priority provider flags in process.env, causing deserializeMessages to resolve a non-GitHub provider and strip thinking blocks even though the test intended to exercise GitHub native Claude transport.

The test now clears provider routing env before setting CLAUDE_CODE_USE_GITHUB=1 and OPENAI_MODEL=claude-sonnet-4-6, then restores the original env values in afterEach.

Verification: bun test src/utils/conversationRecovery.test.ts; bun test --max-concurrency=1.

* test: isolate conversation recovery provider state

* test: pin conversation recovery provider mock

* test: isolate knowledge graph persistence

* fix: make knowledge graph reset synchronous

* test: restore integration registry after unit tests

* remove plans dir

* delete plans

* Fix provider routing test failures

Restore the missing first-party Anthropic auth routing imports used by getAnthropicClient so OpenAI-compatible provider client creation no longer throws at runtime.

Keep GitHub provider resolution from inheriting OPENAI_API_FORMAT=responses so GitHub GPT-4 and gpt-5-mini models continue to use chat completions while Codex-flavored models still route to responses.

Reset OPENAI_API_FORMAT in the affected API provider tests to prevent environment leakage across serial Bun test runs.

Verified with: bun test --max-concurrency=1

* fix: restore provider-specific model routing

Resolve generic OpenAI-compatible profiles by their known descriptor base URLs so saved MiniMax, xAI, NVIDIA NIM, OpenRouter, and DeepSeek profiles use the correct route catalogs instead of the generic OpenAI model list.

Fix MiniMax defaults and display handling so provider-specific model IDs are not rendered as Claude Opus defaults, add current MiniMax M2.7 options, and cover the regressions with focused route/model tests.

Also clean up descriptor follow-ups from review: remove the dead OpenAI shim store-strip fallback list, preserve gateway vendor IDs for Bedrock/Vertex/GitHub profile resolution, and keep the ModelPicker compiled-form changes in this PR.

* test: cover provider precedence review fixes

Remove import-time ANTHROPIC_BASE_URL and ANTHROPIC_MODEL reads from the Anthropic descriptor so descriptor defaults stay static and live env handling remains in preset metadata.

Add getAPIProvider precedence coverage documenting that explicit Gemini/OpenAI flags beat env-only MiniMax API key inference.

Add a regression check to keep the removed openaiShim hardcoded descriptor route fallback list from returning.

---------

Co-authored-by: TechBrewBoss <dash@hicap.ai>
discopops pushed a commit to discopops/openclaude that referenced this pull request May 28, 2026
…Models (Twigpine#910)

* setting up

* updated plan with missing notes for discovery cache

* build out inital checklist and planning adjustments

* Phase 1A-1D

* Fix descriptor-backed provider profile routing

- preserve GitHub, Bedrock, and Vertex runtime flags during profile activation\n- serialize descriptor-backed startup profiles into legacy-compatible persisted kinds\n- add regression coverage for activation, restart round-trip, and saved-profile switching\n- guard integration registration so repeated imports stay idempotent in tests

* feat: finish phase 1 provider descriptor routing

Complete the Phase 1E CLI/usage migration work and the Phase 1F verification pass for descriptor-backed providers.

Details:

- derive valid --provider values from descriptor registry and compatibility mappings instead of a fixed list

- preserve special CLI semantics for ollama and minimax while allowing descriptor-backed OpenAI-compatible routes such as deepseek and openrouter to pick up descriptor base URLs

- add getUsageDescriptor() so /usage resolves vendor/gateway metadata and follows usage delegation

- switch Settings Usage rendering to descriptor-backed usage resolution for Anthropic, MiniMax, and neutral unsupported fallbacks

- make integration loading idempotent via ensureIntegrationsLoaded() so registry-backed helpers survive tests that clear the registry

- fix compatibility mapping for mistral so the preset routes through vendorId=openai with gatewayId=mistral rather than a nonexistent direct vendor route

- harden provider profile and startup tests so descriptor-backed providers, legacy OpenAI startup files, and unknown stored providers round-trip correctly

- remove a stale ollama model mock that was leaking across the full model test suite

- update plan/progress.md with the current 1E complete / 1F in-progress verification state and the note that repo-wide typecheck failures are pre-existing outside this migration slice

Verification:

- bun test src/commands/usage/index.test.ts src/integrations/compatibility.test.ts src/utils/providerFlag.test.ts src/utils/providerProfiles.test.ts src/utils/providerProfile.test.ts src/utils/model/modelCache.test.ts src/integrations/index.test.ts src/integrations/registry.test.ts

- filtered bun run typecheck output for the files changed in this branch is clean

* Phase 2 planning

* feat: complete phase 2A validation and discovery cache

* fix: address review findings for phase 2 cache and validation

Fixes the follow-up review issues from the Phase 2A / 2A.5 work.

Completed work:

- made discovery cache stale entries reachable through getCachedModels(..., { includeStale: true }) while keeping fresh-by-default behavior unchanged

- kept recordDiscoveryError stale-data preservation useful to later /model consumers by exposing stale and error-only entries through the public helper API

- extended descriptor-backed validation routing metadata with host alias matching support

- updated MiniMax validation routing to recognize both api.minimax.io and api.minimax.chat endpoints

- added regression coverage for stale cache reads, error-only cache entries, and MiniMax chat-host validation

- updated progress.md notes so the recorded 2A.5 helper behavior matches the implementation

* feat: complete phase 2B discovery and readiness migration

Implement descriptor-backed discovery and readiness routing for Phase 2B.

Highlights:

- add src/integrations/discoveryService.ts to execute declarative catalog.discovery configs with shared discovery-cache integration

- add hybrid merge behavior so curated descriptor catalog entries stay ahead of discovered duplicates

- add typed startup readiness metadata via ReadinessProbeKind and wire gateway descriptors for ollama, atomic-chat, lmstudio, and openrouter

- export probeOllamaModelCatalog() so discovery can distinguish unreachable Ollama from reachable-but-empty catalogs

- migrate ProviderManager and /provider flows to probeRouteReadiness() while preserving existing Ollama messaging

- route bootstrap local model discovery through descriptor-backed discovery for recognized local routes, while keeping legacy fallback for generic custom endpoints

- add resolveDiscoveryRouteIdFromBaseUrl() so bootstrap can share descriptor-backed discovery and local provider labels

- preserve explicit provider env precedence during applySavedProfileToCurrentSession() after focused verification exposed the regression

- update plan/progress.md to mark Phase 2B complete and record the verification notes

Verification:

- bun test src/integrations/discoveryService.test.ts

- bun test src/components/ProviderManager.test.tsx

- bun test src/commands/provider/provider.test.tsx

- bun test src/utils/providerDiscovery.test.ts src/integrations/registry.test.ts src/integrations/index.test.ts

- filtered bun run typecheck for the touched 2B files returned FILTER_CLEAN

* feat: complete phase 2c provider metadata migration

Finish the Phase 2C runtime metadata adoption work on cheeky-cooking-moon.

Provider UI metadata:

- add shared route metadata and provider preset UI metadata helpers

- move preset labels/defaults, route type labels, and custom-header capability checks onto descriptor-backed lookups

- update ProviderManager and /provider summaries/setup copy to read shared descriptor metadata instead of bespoke switches

- extend local gateway descriptors with default model metadata used by the shared UI helpers

Model discovery UX:

- add route catalog option builders for descriptor-backed /model rendering

- update /model to resolve the active route, read cached route catalogs before rendering, and trigger background refresh when cached discovery is stale

- add /model refresh plus in-picker refresh via modelPicker:refresh and the r keybinding

- clear discovery cache on manual refresh and surface non-blocking loading/success/stale-error states in ModelPicker

- keep descriptor-backed dynamic and hybrid routes on the shared discovery cache service

Verification and hardening:

- fix combined test pollution by isolating /model test module imports and using real OpenRouter descriptor metadata during shared runs

- update progress.md to mark Phase 2C complete with verification notes

- verified with bun test for provider profiles, ProviderManager, /provider, /model, discovery cache, and provider validation suites

* feat: complete phase 2d runtime provider alignment

Align descriptor-backed runtime provider behavior with the legacy APIProvider surface so active routes, OpenAI shim behavior, and resume handling all resolve through the same metadata path.

Add runtimeMetadata.ts to centralize active route detection, OpenAI shim overrides, and native-format inference. Update provider resolution to map descriptor-backed routes onto legacy provider categories while preserving existing compatibility fallbacks for Foundry, NVIDIA NIM, MiniMax, GitHub, Bedrock, and Vertex.

Move request-shaping rules onto descriptor metadata for DeepSeek, Moonshot, Kimi Code, Gemini, Mistral, GitHub, and local gateways, including reasoning_content preservation, deepseek-compatible thinking payloads, max_tokens field selection, and store field stripping. Treat GitHub Claude native transport as Anthropic-native during conversation recovery so thinking blocks survive resume flows.

Extend focused tests for provider resolution, OpenAI shim request shaping, and conversation recovery, and update phase tracking notes in progress.md to mark 2D complete with verification details.

* feat: complete phase 2e drift audit

Complete the Phase 2E verification and drift-audit packet for the descriptor migration branch.

Add representative provider-summary coverage for descriptor-backed OpenRouter routing plus Gemini and Mistral current-provider summaries in src/commands/provider/provider.test.tsx. Extend ProviderManager coverage with first-run Atomic Chat discovery-backed setup and a regression test proving the set-active picker now uses descriptor-backed provider-type labels.

Replace stale saved-profile picker wording in ProviderManager so saved profiles no longer collapse to a coarse anthropic/openai-compatible split and instead render the route's descriptor-backed provider type label.

Add plan/phase-2e-drift-audit.md documenting the remaining intentional switch sites and non-switch provider branches across provider summaries, active-route detection, OpenAI shim env remapping, auth/header exceptions, and conversation recovery. Update plan/progress.md to mark Phase 2 and 2E complete on-branch, record focused verification, and note the follow-up hardening completed during audit review.

Verification completed during this packet: bun test src/components/ProviderManager.test.tsx src/commands/provider/provider.test.tsx src/utils/providerValidation.test.ts src/integrations/discoveryService.test.ts src/commands/model/model.test.tsx and bun test src/utils/providerDiscovery.test.ts src/utils/model/providers.test.ts src/services/api/openaiShim.test.ts src/utils/conversationRecovery.test.ts. Filtered typecheck output still shows pre-existing baseline noise in src/services/api/openaiShim.ts and src/utils/conversationRecovery.ts only.

* fix: close phase 2 provider parity follow-through

Complete the skipped provider-surface follow-up discovered during the post-Phase-2 review.

- add focused status coverage for NVIDIA NIM and MiniMax sessions

- add Mistral entries to legacy teammate/model compatibility configs

- fill deprecation placeholders for the widened APIProvider surface

- add focused regression tests for status and teammate fallbacks

- update the Phase 2 drift audit and progress tracker with the compatibility-bridge notes and Phase 3 staging context

* phase 3 planning

* refactor: start phase 3a dead-switch cleanup

Begin the Phase 3 cleanup pass with the metadata-only dead-switch removals that are safe to land independently on cheeky-cooking-moon.

Completed work:

- updated plan/progress.md to move Phase 3 and Phase 3A into IN_PROGRESS, added slice-level checklists, and recorded what remains intentionally deferred to later packets

- removed duplicated OpenAI-compatible status-display branches in src/utils/status.tsx by routing openai/codex/nvidia-nim/minimax through shared metadata helpers

- replaced the pure transport-kind label switch in src/integrations/routeMetadata.ts with shared label metadata

- replaced the pure provider-label switch in src/components/CostThresholdDialog.tsx with a shared provider-label map

- added focused regression coverage in src/utils/status.test.ts, src/integrations/routeMetadata.test.ts, and src/components/CostThresholdDialog.test.ts

Verification:

- bun test src/utils/status.test.ts src/utils/swarm/teammateModel.test.ts src/utils/model/providers.test.ts

- bun test src/integrations/routeMetadata.test.ts src/utils/status.test.ts src/components/CostThresholdDialog.test.ts src/utils/model/providers.test.ts

- filtered bun run typecheck for the touched status/routeMetadata/CostThresholdDialog files returned FILTER_CLEAN

* refactor: complete phase 3b and 3c cleanup

Complete the uncommitted Phase 3B compatibility rename work and the Phase 3C env-shaping consolidation on cheeky-cooking-moon.

Phase 3B:
- introduce LegacyAPIProvider while keeping APIProvider as the public compatibility alias
- introduce LegacyProviderModelConfig and LEGACY_PROVIDER_MODEL_CONFIGS while keeping ModelConfig and ALL_MODEL_CONFIGS as compatibility exports
- switch modelStrings, deprecation helpers, and provider profile compatibility naming onto the legacy/compatibility terminology

Phase 3C:
- add shared managed-env clear/apply helpers in providerProfile.ts and route buildLaunchEnv through the shared compatibility env shaper
- route applyProviderProfileToProcessEnv through the same compatibility env shaper so config-backed profiles and startup/session env construction stay aligned
- preserve explicit exception behavior for github, mistral, bedrock, vertex, bankr aliasing, MiniMax fallback detection, and NVIDIA NIM mode markers
- reduce createOpenAIShimClient to the remaining credential alias hydration that resolveProviderRequest does not already cover
- fix applySavedProfileToCurrentSession so saved-profile switching can move away from stale GitHub env selections
- add regression coverage for NVIDIA NIM env stamping and stale Codex-managed env clearing
- update progress.md to mark Phase 3B and 3C complete on branch and record the verification notes

Verification:
- bun test src/utils/model/providers.test.ts src/utils/providerProfiles.test.ts src/utils/swarm/teammateModel.test.ts src/utils/status.test.ts
- bun test src/utils/providerProfile.test.ts src/utils/providerProfiles.test.ts src/services/api/openaiShim.test.ts
- filtered bun run typecheck confirmed no new hits in providerProfile.ts or providerProfiles.ts; remaining openaiShim.ts hits are existing repo baseline debt

* docs: complete phase 3d audit and architecture note

Complete the Phase 3D final audit/documentation packet on cheeky-cooking-moon.

Work completed:
- add plan/phase-3d-final-audit.md with the final post-Phase-3 inventory of remaining provider-specific runtime branches
- classify the remaining exceptions as intentional long-term runtime differences or temporary env/config compatibility bridges
- confirm the audit did not uncover new missed runtime migration work that requires additional Phase 3 code changes
- add docs/architecture/integrations.md to document the descriptor-first architecture, current constraints, known exceptions, and follow-on guidance for future cleanup
- update plan/progress.md to mark Phase 3D complete on branch, mark 3C merged on branch, and point the tracker at Phase 4A next

Key exception categories documented:
- github dual-mode transport behavior
- mistral dedicated route/runtime shaping
- bedrock/vertex/foundry native Anthropic-family paths
- Azure and Bankr request-auth/header differences
- Gemini, DeepSeek, and Moonshot/Kimi OpenAI-shim quirks
- MiniMax dedicated usage handling
- native web-search gating
- env-only MiniMax and NVIDIA NIM compatibility fallbacks
- env/config compatibility bridges such as route detection, --provider shaping, and startup/provider summaries

Notes:
- this packet is branch-local audit/documentation work only; no runtime code paths were changed
- no new tests were required for the audit/doc pass

* docs: stage phase 4 tracker and codex profile guard

Add the Phase 4 documentation/reference-samples plan to progress.md in the same packet/checkpoint structure as earlier phases, and reconcile the Phase 3 tracker summary with the completed cleanup state. Also fix applySavedProfileToCurrentSession so Codex saved-profile activation does not overwrite an already explicit live provider selection, while still clearing stale profile-managed markers when needed.

* docs: complete phase 4a and 4b guides

Expand the integrations architecture note with descriptor authoring, routing-contract, transport-boundary, and compatibility-layer guidance. Add overview and glossary docs under docs/integrations/, plus new how-to guides for adding vendors and gateways with one-file and two-file patterns, discovery cache guidance, token-field guidance, and compatibility follow-through. Update progress.md to mark Phase 4 in progress, Phase 4A complete, and Phase 4B complete with notes about the new docs structure and guide outputs.

* docs: complete phase 4 integration docs

Add the remaining descriptor contributor guides for models, anthropic proxies, and /usage support.

Add a reference sample pack and a common-pitfalls checklist, update the integrations overview, and reconcile plan/progress.md so Phase 4 is marked complete on cheeky-cooking-moon with the current implementation boundaries called out explicitly.

* docs: reconcile tracker waivers and checkpoints

Update plan/progress.md to formally waive the remaining repo-wide typecheck item for Phase 1F as pre-existing debt outside the descriptor migration scope, and mark the Phase 4 branch-local checkpoints as landed on cheeky-cooking-moon with the corresponding commit references.

* Align Z.AI merge fallout with descriptors

Reviewed the upstream main merge against plan/cheeky-cooking-moon.md and removed drift from the old switch/helper-based Z.AI provider path.

Moved Z.AI reasoning, context-window, and max-output metadata into the descriptor route catalog so thinking support can read catalog capabilities instead of URL/model helper checks.

Removed the standalone src/utils/zaiProvider.ts helper and updated startup/provider-discovery labeling to resolve known direct routes through descriptor route metadata.

Simplified --provider handling for Z.AI by letting descriptor defaults provide the base URL and default model through the generic OpenAI-compatible provider branch.

Updated startup and provider-discovery tests for descriptor-backed labels, added Z.AI descriptor-label coverage, and documented the post-main-merge reconciliation in plan/progress.md.

Verification before commit: bun test src/utils/providerFlag.test.ts src/utils/providerProfiles.test.ts src/utils/thinking.test.ts src/components/StartupScreen.test.ts src/utils/providerDiscovery.test.ts; bun test src/integrations/compatibility.test.ts src/integrations/index.test.ts src/integrations/registry.test.ts src/services/api/openaiShim.test.ts; git diff --check.

* fix: restore descriptor migration behavior and isolate provider tests

Restore the descriptor-era Anthropic/OpenAI boundary during conversation recovery by threading the legacy provider category into usesAnthropicNativeMessageFormat instead of relying on ambient env-only route detection.

Harden branch-added provider-facing tests so they do not inherit leaked bun mock.module state from neighboring suites. Status, thinking, teammate fallback, and GitHub model options tests now restore mocks and/or import fresh modules under explicit provider context.

Update bugfix assertions to validate the descriptor-backed openaiShim contract for removeBodyFields/store stripping instead of the pre-refactor inline conditionals.

Validation:
- focused status/thinking/conversationRecovery/bugfix suites pass
- full bun test --max-concurrency=1 is down to the existing conversationArc perf benchmark failure only
- bun run smoke
- bun run build
- npm pack

* fix: close descriptor review drift and provider regressions

Address the follow-up review against plan/cheeky-cooking-moon.md by fixing the remaining runtime drift and locking the behavior with focused coverage.

Completed work:

- make NVIDIA NIM descriptor-backed auth consistent across validation, --provider env shaping, and openaiShim request auth so NVIDIA_API_KEY works without requiring OPENAI_API_KEY

- resolve /usage from the active descriptor route instead of collapsing most OpenAI-compatible providers into the legacy openai bucket

- honor discoveryRefreshMode in /model so manual, on-open, background-if-stale, and startup catalogs no longer behave identically

- clarify docs/progress notes so the branch no longer overstates one-file additive onboarding while loader and preset/UI compatibility surfaces are still manual

Verification:

- bun test src/services/api/openaiShim.test.ts src/utils/providerValidation.test.ts src/utils/providerFlag.test.ts src/utils/model/providers.test.ts src/commands/usage/index.test.ts src/commands/model/model.test.tsx

* docs(plan): require descriptor-native gateway onboarding closure

Investigated the current descriptor onboarding flow and documented the remaining manual choke points in the loader, preset compatibility mapping, provider UI metadata, and handwritten preset typing.

Tighten cheeky-cooking-moon so additive onboarding is a hard requirement, add Phase 3E for descriptor-native onboarding closure, and update the progress tracker to reflect that follow-up work instead of treating the branch as fully complete.

* feat(integrations): close descriptor-native onboarding

Implement the Phase 3E generated-artifact workflow for integration onboarding.

- add integration artifact generation and check scripts

- generate loader inventory, preset manifest, and preset type from descriptors

- move preset participation onto descriptor preset metadata for preset-facing vendors and gateways

- derive compatibility and provider UI metadata from the generated manifest

- remove descriptor-level preset ordering and sort presets by description with standard alphanumeric ordering

- pin the custom preset to the bottom automatically in generated ordering

- add validation for duplicate preset ids and incomplete preset metadata

- add generator tests for representative gateway and direct-vendor onboarding

- refresh ProviderManager tests for generated preset ordering

- update architecture/how-to/reference docs and progress tracking for the new regeneration workflow

* Fix provider profile and discovery drift

Honor route-specific auth env vars across descriptor-backed OpenAI-compatible routes by centralizing credential resolution and using it in validation, bootstrap, discovery, and the OpenAI shim.

Persist Anthropic startup fallbacks as native anthropic profiles and restore them correctly at startup so the legacy startup file stays aligned with the active provider.

Wire discoveryRefreshMode='startup' into startup and provider activation flows, with LM Studio as a live startup-refresh example, and add regression coverage for validation, startup env shaping, discovery refresh, and shim auth handling.

* Pin Anthropic provider preset to the top

Keep the existing custom gateway preset pinned to the bottom while moving the Anthropic preset ahead of the description-sorted remainder.

Regenerate the integration preset manifest/order and extend the artifact generator coverage to lock in both ordering rules.

Validation: bun test src/integrations/artifactGenerator.test.ts src/components/ConsoleOAuthFlow.test.tsx; bun run build

* docs: refresh integration and setup guides

Update the new descriptor-era integration docs so they read as current contributor guidance instead of rollout notes, and align the authoring examples with the actual runtime metadata flow.

Highlights:

- add a CONTRIBUTING.md pointer to the integration overview and focused how-to guides

- remove branch/phase-specific wording from the integration docs

- fix OpenAI-compatible header guidance to use transportConfig.openaiShim headers and custom-header flags

- clarify anthropic proxy onboarding around generated loader support

- refresh advanced setup with current Codex, Gemini, Mistral, and profile-launch details

- fix LiteLLM /provider instructions and clarify local no-auth behavior

- tighten quick-start and non-technical cross-links so users can find the advanced provider docs

* fix: close descriptor integration drift

Apply descriptor-backed static headers to OpenAI-compatible request execution and model discovery, preserving request-specific header precedence.

Allow Gemini profile launch with API key, access-token, or ADC credentials, and align Gemini fallback defaults with the descriptor/docs default model.

Add regression coverage for descriptor header propagation, Gemini defaults, and discovery auth/header behavior.

* post-phase follow-up task added

* Fix xAI merge follow-ups

Route env-only XAI_API_KEY sessions through the OpenAI-compatible shim using descriptor-backed xAI defaults, and map the xAI key into OPENAI_API_KEY for shim auth.

Hydrate legacy profile: xai startup env with xAI descriptor defaults, preserving XAI_API_KEY and OpenAI-compatible launch behavior.

Update progress tracking for post-merge xAI descriptor inventory and clarify that profile-owned custom headers remain open despite adjacent auth/static-header plumbing.

Add regression coverage for env-only xAI client routing, legacy xAI launch env, shell key precedence, and the Gemini/OpenAI client test isolation issue.

* Complete profile custom headers follow-up

Add persisted provider-profile customHeaders support with shared parsing and sanitization for compact Name: value input. Reject malformed and reserved auth/internal headers before saving or applying profile-owned headers.

Expose a descriptor-gated /provider custom headers step, preserve headers during profile edit/update, and apply supported profile headers through ANTHROPIC_CUSTOM_HEADERS for active env and startup fallback profiles.

Propagate profile headers into descriptor discovery refresh and bootstrap model discovery while preserving descriptor/profile/auth merge order. Add focused regression coverage and mark the progress tracker packet complete.

* Allow api-key custom provider headers

Permit api-key in /provider custom header input and preserve it when OpenAI-compatible shim requests are built. This is intentional for gateway providers that require an api-key header in addition to, or instead of, standard bearer auth.

Keep managed credential headers protected by continuing to reject/strip authorization and x-api-key, plus Anthropic/Claude-owned headers. Add parser, profile env, and outgoing request coverage for the intended behavior.

* fix: restore API mode picker for OpenAI-compatible profiles

Use descriptor transport metadata instead of the legacy provider id when deciding whether provider profiles support OpenAI-compatible options. This restores the Chat Completions vs Responses picker for the Custom OpenAI-compatible preset after it moved to the descriptor-backed custom route.

Preserve apiFormat and custom auth header profile fields for all routes whose transportConfig.kind is openai-compatible, so selecting Responses is saved and applied as OPENAI_API_FORMAT=responses.

Tests: bun test src/components/ProviderManager.test.tsx; bun test src/utils/providerProfiles.test.ts; bun run build; bun run smoke

* fix: respect explicit provider routing with xAI env

Ensure env-only XAI_API_KEY fallback does not take over when Bedrock, Vertex, or Foundry has been explicitly selected. This preserves native transport routing while still allowing bare xAI env setup to use the OpenAI-compatible shim.

Restore api-key to the managed custom-header blocklist now that /provider exposes the API mode/auth-header controls for OpenAI-compatible profiles. The shim and provider override paths strip api-key again, while OPENAI_AUTH_HEADER=api-key remains available for explicit auth configuration.

Tests: bun test src/services/api/client.test.ts src/utils/providerCustomHeaders.test.ts src/utils/providerProfiles.test.ts src/services/api/openaiShim.test.ts; bun run build; bun run integrations:check; bun run smoke

* docs: fix integration drift

Align integration and setup docs with the current implementation.

- show model descriptor examples as array default exports, matching the generated MODEL_DESCRIPTOR_GROUPS loader contract

- document provider-scoped model env vars instead of implying OPENAI_MODEL globally overrides ANTHROPIC_MODEL

- clarify generated provider preset ordering: anthropic first, custom last, description-sorted middle entries

- update LiteLLM examples and /provider guidance to use the /v1 OpenAI-compatible base URL

Verification: bun run integrations:check

* Fix provider discovery cache isolation

* Stabilize provider env tests

* Stabilize provider test isolation

Completed work:

- Isolated GitHub model option tests from cached availableModels settings.

- Isolated startup discovery tests from live process.env provider flag races.

- Mocked teammate provider fallback tests at the provider helper boundary.

- Moved cost threshold provider labels into a pure helper for deterministic tests while preserving runtime active-provider behavior.

Validation:

- bun test src/components/CostThresholdDialog.test.ts src/integrations/discoveryService.test.ts src/utils/model src/utils/swarm

- bun run build

- bun run smoke

* test: isolate startup screen model settings

Clear the session settings cache and persisted global model around StartupScreen provider-detection tests.

This prevents earlier provider/model suites from leaking saved non-Anthropic models into the default Anthropic startup assertions.

Verified with: bun test src/components/StartupScreen.test.ts src/integrations/discoveryService.test.ts src/utils/model/modelOptions.github.test.ts

Full bun test now only fails the unrelated Conversation Arc sub-millisecond performance benchmark.

* test: isolate route discovery and github model options

Restore Bun module mocks around discoveryService tests before loading fresh route-discovery modules.

Pin the GitHub model-options test to a complete providers.js mock so cached provider mocks from other suites cannot hide Copilot options.

Verified with: bun test src/integrations/discoveryService.test.ts src/utils/model/modelOptions.github.test.ts

Also ran full bun test; only the unrelated Conversation Arc sub-millisecond performance benchmark fails locally.

* test: avoid startup discovery cache collision

Use the 127.0.0.1 LM Studio alias in refreshStartupDiscoveryForActiveRoute so it still resolves the active route from env but does not share the cache partition with the preceding startup refresh test.

This keeps the assertion on network refresh stable under Bun 1.3.11 serialized runs.

Verified with: bun test --max-concurrency=1 src/integrations/discoveryService.test.ts src/utils/model/modelOptions.github.test.ts

Also ran full bun test --max-concurrency=1; only the unrelated Conversation Arc perf benchmark fails locally.

* fix: isolate OpenAI-compatible route credentials

Restrict OpenAI-compatible shim auth to provider overrides, resolved route credentials, or explicit OPENAI_API_KEY instead of ambient provider-specific secrets.

Remove NVIDIA and Bankr compatibility fallbacks that could promote provider-specific API keys into unrelated OpenAI-compatible routes. Preserve Bankr base URL/model compatibility before route credential resolution so Bankr still resolves through descriptor credentials.

Clear stale NVIDIA_NIM and copied OPENAI_API_KEY values when switching away from NVIDIA NIM, Bankr, or xAI provider flags to avoid carrying provider secrets across route boundaries.

Add regressions for stale NVIDIA, MiniMax, and Bankr keys not leaking into OpenRouter-style routes, plus provider-flag cleanup for copied NVIDIA/Bankr/xAI keys.

Validation: bun test src/services/api/openaiShim.test.ts; bun test src/utils/providerFlag.test.ts; bun run build; bun run smoke.

* fix: guard model discovery privacy paths

Suppress descriptor and legacy model discovery while essential-only traffic mode is active.

Use the partitioned discovery cache key for /model cache reads, stale checks, and manual refresh clears, including route-specific credentials and custom headers.

Partition legacy local OpenAI additional model caches by credentials and routing headers to avoid catalog reuse across profiles.

Add coverage for OpenRouter route credentials, descriptor privacy suppression, legacy discovery privacy suppression, and local cache scope partitioning.

* Fix artifact checks and knowledge graph persistence

Normalize generated integration artifact comparisons so Windows line endings do not make checked-in artifacts appear stale.

Skip knowledge graph entity persistence when re-adding an existing entity with identical attributes, avoiding repeated disk writes during automatic fact extraction and restoring the conversation arc performance benchmark.

Verified with bun test src/integrations/artifactGenerator.test.ts --max-concurrency=1, bun test src/utils/conversationArc.perf.test.ts --max-concurrency=1, and bun test --max-concurrency=1.

* test: isolate privacy discovery cache path

The descriptor discovery privacy test could observe stale OpenRouter cache data populated by an earlier test and receive source=stale-cache instead of static. Use a test-specific API key so the privacy assertion gets its own discovery cache partition while still verifying that nonessential traffic disables network discovery.

Verified with bun test src/integrations/discoveryService.test.ts --max-concurrency=1 and bun test --max-concurrency=1.

* test: accept cached privacy discovery result

* test: set privacy gate before discovery import

* test: prevent discovery privacy mock bleed

Guard descriptor model discovery directly on CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC so nonessential traffic stays disabled even if the privacyLevel module is mocked in-process.

Reduce broad fastMode test mocks for shared modules and use real state/config test hooks, preventing Bun module mock namespaces from leaking into discovery and /model tests.

Verified with bun test src/utils/fastMode.test.ts src/utils/model/openaiModelDiscovery.test.ts src/integrations/discoveryService.test.ts src/commands/model/model.test.tsx --max-concurrency=1 and bun test --max-concurrency=1.

* test: prevent discovery privacy mock bleed

Add an env-level fallback guard to descriptor model discovery so disabled nonessential traffic cannot be bypassed by stale mocked privacy helpers.

Tighten the fastMode regression tests by setting real bootstrap/config state only after the tested module is imported, avoiding broad module mocks that can leak into unrelated discovery tests or behave differently under Bun in CI.

Verified with focused discovery/fastMode/model suites and the full serial bun test suite.

* fix: harden fast mode test isolation

Ignore non-string GrowthBook values when resolving the fast mode unavailable reason so boolean flag payloads cannot surface as false.

Make the affected regression tests install explicit provider mocks for their own scenarios and reset env state, preventing stale provider mocks from changing fastMode and conversation recovery behavior across the serial Bun test run.

* test: harden fast mode module mocks

Expand the fastMode GrowthBook and provider test mocks so later imports in the same Bun test process can resolve the named exports they expect. This prevents order-sensitive failures when model command tests run after fast mode tests.\n\nVerified with: bun test --max-concurrency=1

* feat: consolidate integration runtime metadata

Move OpenAI-compatible model runtime limits into descriptor-backed brand and model metadata, adding Gemini, GLM, MiniMax, Mistral, Nemotron, xAI, and OpenAI-compatible alias descriptor groups. Update generated integration artifacts, route catalog option handling, thinking capability lookup, and docs to use modelDescriptorId-backed runtime metadata.

Split OpenAI shim capability flags into supportsApiFormatSelection and supportsAuthHeaders, and update provider profile sanitization, ProviderManager forms, descriptor validation, and integration authoring docs so fixed routes do not preserve unsupported API format or auth-header settings.

Harden env-only MiniMax and xAI routing. Resolve shared route intent before client setup, reject conflicting OpenAI base URLs, preserve provider-specific base overrides, sanitize stale OpenAI shim knobs, copy provider credentials intentionally, and keep legacy provider labels, context windows, max output limits, model lists, and provider switching aligned.

Refresh MiniMax defaults and catalog entries, add descriptor-backed runtime limits for migrated models, preserve external OpenAI limit overrides, and add regression coverage for env-only MiniMax/xAI, provider-profile capability stripping, route catalog options, copied credential cleanup, and context/runtime limit detection.

Verification performed: bun test src/utils/providerFlag.test.ts; bun test src/services/api/client.test.ts src/utils/model/providers.test.ts src/integrations/routeMetadata.test.ts; bun test src/utils/context.test.ts src/utils/thinking.test.ts src/services/compact/autoCompact.test.ts; bun test src/integrations/routeMetadata.test.ts src/services/api/client.test.ts src/utils/model/providers.test.ts src/utils/providerValidation.test.ts src/integrations/index.test.ts src/utils/status.test.ts; bun run build; bun run smoke.

* test: isolate provider env in conversation recovery

Snapshot and restore all provider-selection environment variables used by the GitHub native Claude resume test instead of only restoring the GitHub flag and OPENAI_MODEL.

The full single-concurrency suite exposed that earlier tests can leave higher-priority provider flags in process.env, causing deserializeMessages to resolve a non-GitHub provider and strip thinking blocks even though the test intended to exercise GitHub native Claude transport.

The test now clears provider routing env before setting CLAUDE_CODE_USE_GITHUB=1 and OPENAI_MODEL=claude-sonnet-4-6, then restores the original env values in afterEach.

Verification: bun test src/utils/conversationRecovery.test.ts; bun test --max-concurrency=1.

* test: isolate conversation recovery provider state

* test: pin conversation recovery provider mock

* test: isolate knowledge graph persistence

* fix: make knowledge graph reset synchronous

* test: restore integration registry after unit tests

* remove plans dir

* delete plans

* Fix provider routing test failures

Restore the missing first-party Anthropic auth routing imports used by getAnthropicClient so OpenAI-compatible provider client creation no longer throws at runtime.

Keep GitHub provider resolution from inheriting OPENAI_API_FORMAT=responses so GitHub GPT-4 and gpt-5-mini models continue to use chat completions while Codex-flavored models still route to responses.

Reset OPENAI_API_FORMAT in the affected API provider tests to prevent environment leakage across serial Bun test runs.

Verified with: bun test --max-concurrency=1

* fix: restore provider-specific model routing

Resolve generic OpenAI-compatible profiles by their known descriptor base URLs so saved MiniMax, xAI, NVIDIA NIM, OpenRouter, and DeepSeek profiles use the correct route catalogs instead of the generic OpenAI model list.

Fix MiniMax defaults and display handling so provider-specific model IDs are not rendered as Claude Opus defaults, add current MiniMax M2.7 options, and cover the regressions with focused route/model tests.

Also clean up descriptor follow-ups from review: remove the dead OpenAI shim store-strip fallback list, preserve gateway vendor IDs for Bedrock/Vertex/GitHub profile resolution, and keep the ModelPicker compiled-form changes in this PR.

* test: cover provider precedence review fixes

Remove import-time ANTHROPIC_BASE_URL and ANTHROPIC_MODEL reads from the Anthropic descriptor so descriptor defaults stay static and live env handling remains in preset metadata.

Add getAPIProvider precedence coverage documenting that explicit Gemini/OpenAI flags beat env-only MiniMax API key inference.

Add a regression check to keep the removed openaiShim hardcoded descriptor route fallback list from returning.

---------

Co-authored-by: TechBrewBoss <dash@hicap.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Registry-Based Integration Architecture for Providers, Gateways, and Models

8 participants