test: align Codex strict schema expectation - #72
Merged
Merged
Conversation
Collaborator
Author
|
@kevincodex1 check this |
3 tasks done
Collaborator
Author
|
@kevincodex1 push this to main first because of this all test cases are failing |
kevincodex1
approved these changes
Apr 2, 2026
gnanam1990
added a commit
to gnanam1990/openclaude
that referenced
this pull request
Apr 2, 2026
Update the stale test expectation to match current behavior where normalizeSchemaForOpenAI() promotes all properties into required[] and marks the schema as strict: true. Same fix as PR Twigpine#72 — included here so PR Twigpine#80 passes CI independently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
euxaristia
pushed a commit
to euxaristia/openclaude
that referenced
this pull request
Apr 13, 2026
test: align Codex strict schema expectation
euxaristia
pushed a commit
to euxaristia/openclaude
that referenced
this pull request
Apr 13, 2026
Update the stale test expectation to match current behavior where normalizeSchemaForOpenAI() promotes all properties into required[] and marks the schema as strict: true. Same fix as PR Twigpine#72 — included here so PR Twigpine#80 passes CI independently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
reymaster
pushed a commit
to reymaster/openclaude
that referenced
this pull request
May 5, 2026
test: align Codex strict schema expectation
reymaster
pushed a commit
to reymaster/openclaude
that referenced
this pull request
May 5, 2026
Update the stale test expectation to match current behavior where normalizeSchemaForOpenAI() promotes all properties into required[] and marks the schema as strict: true. Same fix as PR Twigpine#72 — included here so PR Twigpine#80 passes CI independently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainWhy
The new
PR Checksworkflow exposed an existing stale expectation incodexShim.test.tsafter #71 merged. The Codex tool-schema normalizer now promotes all properties intorequiredand marks the resulting tool schema asstrict, but the test was still expecting the older non-strict shape.Validation
bun test src/services/api/codexShim.test.tsbun run smokebun run test:providernpm run test:provider-recommendation