cleanup: remove dead USER_TYPE branches from non-stubbed modules

[Flo5k5]

Summary

• Remove ~45 process.env.USER_TYPE === 'ant' checks that gate purely internal/dead code across 28 source files
• Continues the cleanup started in cleanup: remove dead USER_TYPE branches from fast mode and setup #315 by gnanam1990
• Categories removed: undercover guards, internal CLI commands (/bridge-kick, /tag, /files, /version), bridge debug infrastructure (fault injection, SIGUSR2 handler, debug handles), internal tool stubs (REPLTool, TungstenTool, ConfigTool, SuggestBackgroundPRTool), internal performance/analytics instrumentation, and internal insights remote host collection

Does NOT touch USER_TYPE gates that protect useful features (agent nesting in constants/tools.ts, effort overrides, sandbox config, computer use).

Files changed (28 files, -607 lines)

Category	Files
Undercover guards	commit.ts, commit-push-pr.ts
Internal CLI commands	bridge-kick.ts, tag/index.ts, files/index.ts, version.ts
Bridge debug infra	replBridge.ts, bridgeMain.ts, bridgeUI.ts, bridgeConfig.ts, initReplBridge.ts, sessionRunner.ts
Internal tools	tools.ts
Internal state/perf	state.ts, print.ts
Internal insights	insights.ts, context-noninteractive.ts
Misc internal code	update.ts, osc.ts, caches.ts, conversation.ts, cost/index.ts, cost/cost.ts, initMode.ts, feedback/index.ts, createMovedToPluginCommand.ts, thinkback-play.ts, readOnlyValidation.ts

Test plan

• bun run build compiles successfully
• bun run smoke passes
• Verify no regressions in external user workflows (commit, PR, feedback, insights commands)
• Verify bridge/remote-control mode still works for non-ant users

[Copilot]

Pull request overview

Removes process.env.USER_TYPE === 'ant'-guarded branches that previously enabled internal-only behaviors across CLI commands, bridge/debug infrastructure, tools registration, and analytics/insights paths—continuing the dead-code cleanup started in #315.

Changes:

• Eliminates ant-only branches for internal CLI commands and internal-only prompt/UX behaviors.
• Removes ant-only bridge debug/fault-injection hooks and related dev overrides.
• Removes ant-only tool wiring and internal insights/remote-host collection logic.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/tools/BashTool/readOnlyValidation.ts	Removes ant-only command allowlist merge from read-only validation.
src/tools.ts	Removes ant-only tool registration paths and internal tool conditional imports.
src/ink/termio/osc.ts	Removes ant-only gating for OSC 21337 support check (now hard-disabled).
src/commands/version.ts	Disables internal-only /version command.
src/commands/thinkback-play/thinkback-play.ts	Removes internal marketplace routing; always uses official marketplace id.
src/commands/tag/index.ts	Disables internal-only /tag command.
src/commands/insights.ts	Removes internal remote-host collection + internal feedback sections from insights flow.
src/commands/initMode.ts	Removes ant auto-enable path for NEW_INIT; now only env-controlled.
src/commands/files/index.ts	Disables internal-only /files command.
src/commands/feedback/index.ts	Removes ant-only suppression from feedback command enablement logic.
src/commands/createMovedToPluginCommand.ts	Removes ant-only plugin-install instructions branch; uses public/private marketplace path only.
src/commands/cost/index.ts	Removes ant-only visibility override for /cost.
src/commands/cost/cost.ts	Removes ant-only “show cost anyway” branch for subscribers.
src/commands/context/context-noninteractive.ts	Removes ant-only internal sections from noninteractive context output.
src/commands/commit.ts	Removes undercover instruction injection branch from commit prompt.
src/commands/commit-push-pr.ts	Removes undercover branch that altered reviewer/changelog/slack steps.
src/commands/clear/conversation.ts	Removes ant-only env session-id mutation during conversation clear.
src/commands/clear/caches.ts	Removes ant-only tungsten session usage cache clearing hook.
src/commands/bridge-kick.ts	Disables internal-only /bridge-kick command.
src/cli/update.ts	Removes ant-only package-name selection from manual update guidance.
src/cli/print.ts	Removes ant-only exit-after-first-render timing path.
src/bridge/sessionRunner.ts	Removes ant-only verbose fallback for bridge session debug logs.
src/bridge/replBridge.ts	Removes ant-only bridge fault injection, SIGUSR2 handler, and debug handle plumbing.
src/bridge/initReplBridge.ts	Removes ant-only session ingress URL override; always uses baseUrl.
src/bridge/bridgeUI.ts	Removes ant-only debug log path banner output.
src/bridge/bridgeMain.ts	Removes ant-only debug log path wiring and session ingress override.
src/bridge/bridgeConfig.ts	Removes ant-only dev override readers for bridge token/base URL (now stubbed).
src/bootstrap/state.ts	Removes ant-only state shape and slow-operation tracking implementation (now no-op).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

This PR continues the cleanup of legacy process.env.USER_TYPE === 'ant' branches by removing ant-only/internal code paths from non-stubbed modules, reducing conditional complexity and dead code in commands, bridge tooling, and internal instrumentation.

Changes:

• Removed ant-only CLI commands/tools and related gating logic (e.g. internal commands, REPL/SuggestBackgroundPR tooling hooks).
• Deleted ant-only bridge debug infrastructure and various internal-only reporting/insights features.
• Simplified several feature/enablement checks by removing USER_TYPE-based overrides.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/tools/BashTool/readOnlyValidation.ts	Removes ant-only command allowlist merge for read-only validation.
src/tools.ts	Removes ant-gated internal tools from the base tool registry (now stubbed to null).
src/ink/termio/osc.ts	Replaces ant-only tab status support with a GrowthBook feature gate.
src/commands/version.ts	Disables the internal-only /version command.
src/commands/thinkback-play/thinkback-play.ts	Removes ant-only marketplace selection logic.
src/commands/tag/index.ts	Disables the internal-only /tag command.
src/commands/insights.ts	Removes ant-only remote host collection + internal feedback sections.
src/commands/initMode.ts	Removes ant-only enablement for NEW_INIT; now env-var controlled.
src/commands/files/index.ts	Disables the internal-only /files command.
src/commands/feedback/index.ts	Removes ant-only hiding behavior for feedback commands.
src/commands/createMovedToPluginCommand.ts	Removes ant-only “private marketplace” install instructions branch.
src/commands/cost/index.ts	Removes ant-only visibility exception for /cost.
src/commands/cost/cost.ts	Removes ant-only “show cost anyway” text path.
src/commands/context/context-noninteractive.ts	Removes ant-only context reporting sections (system tools/prompt/message breakdown).
src/commands/commit.ts	Removes ant-only undercover prompt prefix injection.
src/commands/commit-push-pr.ts	Removes ant-only undercover prompt alterations (reviewer/changelog/slack steps).
src/commands/clear/conversation.ts	Removes ant-only session-id env var update during conversation clear.
src/commands/clear/caches.ts	Removes ant-only Tungsten usage tracking cleanup hook.
src/commands/bridge-kick.ts	Disables the internal-only /bridge-kick command.
src/cli/update.ts	Removes ant-only package name selection; always references @anthropic-ai/claude-code.
src/cli/print.ts	Removes ant-only early-exit performance timing behavior.
src/bridge/sessionRunner.ts	Removes ant-only implicit verbose logging behavior for bridge session logs.
src/bridge/replBridge.ts	Removes ant-only fault injection/debug handles and SIGUSR2 reconnect hook.
src/bridge/initReplBridge.ts	Removes ant-only Session-Ingress URL override selection logic.
src/bridge/bridgeUI.ts	Removes ant-only “internal logs path” status output.
src/bridge/bridgeMain.ts	Removes ant-only debug log path behavior and Session-Ingress URL override logic.
src/bridge/bridgeConfig.ts	Makes bridge base URL/token overrides generally available (no longer ant-gated).
src/bootstrap/state.ts	Removes ant-only slow-operation tracking by turning addSlowOperation into a no-op.

Comments suppressed due to low confidence (1)

src/tools/BashTool/readOnlyValidation.ts:1144

• After removing the ant-only allowlist merge, the GH_READ_ONLY_COMMANDS import from readOnlyCommandValidation.js appears to be unused in this module. Please remove the now-unused import to avoid keeping dead validation maps in the bundle and to keep the allowlist source-of-truth clear.

function getCommandAllowlist(): Record<string, CommandConfig> {
  let allowlist: Record<string, CommandConfig> = COMMAND_ALLOWLIST
  // On Windows, xargs can be used as a data-to-code bridge: if a file contains
  // a UNC path, `cat file | xargs cat` feeds that path to cat, triggering SMB
  // resolution. Since the UNC path is in file contents (not the command string),

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Vasanthdev2004]

Review: PR #637 — Remove dead USER_TYPE branches from non-stubbed modules

Reviewed on head 44e357d. CI green ✅. kevincodex1 approved. 28 files, +42/-715.

All 5 Copilot comments addressed in commit f37ccad:

• ✅ supportsTabStatus() now uses GrowthBook tengu_terminal_sidebar instead of hardcoded false
• ✅ getBridgeTokenOverride()/getBridgeBaseUrlOverride() ungated — return env vars directly without USER_TYPE check
• ✅ Dead ConfigTool/TungstenTool imports removed from tools.ts
• ✅ ANT_ONLY_COMMAND_ALLOWLIST and unused GH_READ_ONLY_COMMANDS import deleted from readOnlyValidation.ts — wait, GH_READ_ONLY_COMMANDS is still imported (line 18). See nits below.
• ✅ Remote collection plumbing fully removed from insights.ts
• ✅ sessionIngressUrl hardcoded to baseUrl — correct for open builds (production Envoy routes session-ingress; the separate port scenario was Anthropic-internal)
• ✅ addSlowOperation() made no-op; dead code cleaned — see nits below
• ✅ eslint-disable narrowed to @typescript-eslint/no-require-imports only — wait, still has combined disable. See nits below.

✅ Scope is correct

PR description accurately states what's removed and what's preserved. The preserved gates (agent nesting in tools.ts, effort overrides, sandbox config, computer use) are all still intact. All removed branches were genuinely ant-only dead code in the open build.

✅ No behavioral regressions

• Bridge debug infrastructure (fault injection, SIGUSR2 handler, debug handles) — internal testing only, correctly removed
• Internal CLI commands (/bridge-kick, /tag, /files, /version) — disabled, not deleted from disk, can be re-enabled if needed
• addSlowOperation() → no-op, getSlowOperations() → always returns EMPTY_SLOW_OPERATIONS
• Undercover instruction injection removed from commit/PR flows — correct
• Internal marketplace routing in thinkback-play simplified to official marketplace only

🟡 Minor nits (non-blocking)

1. GH_READ_ONLY_COMMANDS import still present in readOnlyValidation.ts line 18. It was only used by the deleted ANT_ONLY_COMMAND_ALLOWLIST. Now a dead import. Should be removed in a follow-up.

2. MAX_SLOW_OPERATIONS still declared in state.ts line 1561 but never referenced (since addSlowOperation is a no-op). The getSlowOperations() implementation still has the full TTL-filtering logic and a stale comment about addSlowOperation() reassigns STATE.slowOperations, but it's effectively unreachable since nothing ever pushes to slowOperations. Should be cleaned up (remove MAX_SLOW_OPERATIONS, simplify getSlowOperations to just return EMPTY_SLOW_OPERATIONS).

3. Combined eslint-disable on line 15 of tools.ts still includes custom-rules/no-process-env-top-level even though the block no longer reads process.env at the top level. Could be narrowed to just @typescript-eslint/no-require-imports. Very minor.

None of these affect correctness or behavior — just dead code tidy-up.

---

Verdict: Approve-ready ✅

Clean, well-scoped dead code removal. All Copilot concerns addressed. CI green. The three minor nits are non-blocking follow-up material.

[kevincodex1]

hello @Flo5k5 kindly you rebase this to latest main and please fix conflicts.

[gnanam1990]

I appreciate the cleanup goal here, but this branch still touches a surprisingly wide surface for what is framed as dead-code removal, including command paths, bridge/session behavior, state handling, and tool wiring. Because this is specifically removing USER_TYPE-guarded behavior, I’m not comfortable approving it from the current verification story alone. I’d want this either split into smaller clearly-auditable pieces or backed by much stronger targeted regression coverage across the affected external paths.

[Flo5k5]

I appreciate the cleanup goal here, but this branch still touches a surprisingly wide surface for what is framed as dead-code removal, including command paths, bridge/session behavior, state handling, and tool wiring. Because this is specifically removing USER_TYPE-guarded behavior, I’m not comfortable approving it from the current verification story alone. I’d want this either split into smaller clearly-auditable pieces or backed by much stronger targeted regression coverage across the affected external paths.

Hey @gnanam1990 , which part is concerning for you ?

[gnanam1990]

Nice cleanup. Appreciate the explicit call-out in the PR body about which USER_TYPE gates are preserved (agent nesting, effort overrides, sandbox, computer use) — that's the right framing. Two things worth a quick spot-check before merging: (1) addSlowOperation is now a no-op, so please confirm there are no readers of STATE.slowOperations expecting live data. (2) CLAUDE_BRIDGE_* dev overrides are now always-on rather than ant-gated — probably fine for a fork, but worth noting in the PR. LGTM.

[jatmn]

Findings

• [P1] Remove the stale bridge debug assignment
  src/bridge/replBridge.ts:1301
  This PR removes the debugFireClose declaration with the ant-only bridge debug handle, but wireTransport still assigns debugFireClose = handleTransportPermanentClose before registering the close handler. Because this module runs in ESM/strict mode, assigning to that undeclared identifier throws a ReferenceError as soon as a bridge transport is wired, so Remote Control/REPL bridge sessions can fail before the close handler is installed. Please remove this assignment and the stale debug comment along with the deleted debug plumbing, or keep an explicitly declared local if a remaining path still needs it.

[jatmn]

Closing as abandoned