Skip to content

test(cli): clean skills temp directories - #1946

Merged
kevincodex1 merged 2 commits into
Twigpine:mainfrom
jatmn:fix/cli-skills-test-errors
Jul 13, 2026
Merged

kevincodex1 merged 2 commits into
Twigpine:mainfrom
jatmn:fix/cli-skills-test-errors

Conversation

@jatmn

@jatmn jatmn commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • clean every temporary root created by cli.skills.test.ts, including assertion and setup failures
  • bound spawned CLI tests with stream cancellation and idempotent process-tree termination so timeout paths also reach cleanup

Impact

  • user-facing impact: none; test-only change
  • developer/maintainer impact: skills entrypoint tests no longer accumulate openclaude-skills-* directories or leave timed-out CLI process trees behind

Testing

  • bun run build (via bun run smoke)
  • bun run smoke
  • bun run check — local restricted-environment baseline has unrelated full-suite git/config/port failures; focused and adjacent suites were used instead
  • focused tests: TMPDIR=<isolated> bun test --feature=UNATTENDED_RETRY --max-concurrency=1 src/entrypoints/cli.skills.test.ts src/cli/handlers/skills.test.ts src/skills/loadSkillsDir.test.ts (47 pass, isolated temp root empty afterward)
  • bun run typecheck
  • bun run typecheck:type-tests
  • bun run scripts/pr-intent-scan.ts --base upstream/main
  • git diff --check upstream/main...HEAD

Notes

  • provider/model path tested: not applicable; test-harness cleanup only
  • screenshots attached (if UI changed): not applicable
  • follow-up work or known limitations: a separate pre-existing variadic-option parsing issue was discovered during review and intentionally kept out of this focused test-cleanup change
  • final reviewed SHA: 08d7b854a44561f3de5c56df80118fa7afd7c9ed

@coderabbitai

coderabbitai Bot commented Jul 12, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 16 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: be68de12-9980-46b1-b2ae-1aca22579d4a

📥 Commits

Reviewing files that changed from the base of the PR and between ffc5a6e and d202cc2.

📒 Files selected for processing (1)
  • src/entrypoints/cli.skills.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jatmn jatmn self-assigned this Jul 12, 2026
@jatmn jatmn added the bug Something isn't working label Jul 12, 2026
@jatmn
jatmn marked this pull request as ready for review July 12, 2026 02:41

@jatmn jatmn left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevincodex1
kevincodex1 merged commit 0dc622e into Twigpine:main Jul 13, 2026
5 checks passed
@jatmn
jatmn deleted the fix/cli-skills-test-errors branch July 13, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants