Repository navigation
feat(agent-routing): model-only agent routes (set the verifier or any agent's model on the current provider) #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kevincodex1
merged 6 commits into
Twigpine:main
from
beardthelion:feat/per-agent-model-routing
Jun 14, 2026
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ac05394
feat(agent-routing): allow model-only agentModels entries in settings…
beardthelion 2ad82f5
feat(agent-routing): resolve model-only agent routes that reuse the c…
beardthelion 6237e43
feat(agent-routing): enforce org model allowlist for model-only agent…
beardthelion b914017
docs(agent-routing): document model-only routes and built-in agent keys
beardthelion 3882ec4
test(agent-routing): stub and assert partial-entry routing warnings
beardthelion dc9d510
test(agent-routing): consolidate shouldEnforceModelAllowlist import
beardthelion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { expect, test } from 'bun:test' | ||
| import { SettingsSchema } from './types.js' | ||
|
|
||
| test('agentModels accepts a model-only entry (no base_url/api_key)', () => { | ||
| const result = SettingsSchema().safeParse({ | ||
| agentModels: { mini: { model: 'gpt-5-mini' } }, | ||
| agentRouting: { verification: 'mini' }, | ||
| }) | ||
| expect(result.success).toBe(true) | ||
| }) | ||
|
|
||
| test('agentModels accepts a bare entry whose key is the model name', () => { | ||
| const result = SettingsSchema().safeParse({ | ||
| agentModels: { 'gpt-5-mini': {} }, | ||
| agentRouting: { verification: 'gpt-5-mini' }, | ||
| }) | ||
| expect(result.success).toBe(true) | ||
| }) | ||
|
|
||
| test('agentModels still accepts a full cross-provider entry', () => { | ||
| const result = SettingsSchema().safeParse({ | ||
| agentModels: { | ||
| ds: { base_url: 'https://api.deepseek.com/v1', api_key: 'sk-ds' }, | ||
| }, | ||
| agentRouting: { verification: 'ds' }, | ||
| }) | ||
| expect(result.success).toBe(true) | ||
| }) | ||
|
|
||
| test('agentModels rejects a non-URL base_url', () => { | ||
| const result = SettingsSchema().safeParse({ | ||
| agentModels: { bad: { base_url: 'not-a-url', api_key: 'sk' } }, | ||
| }) | ||
| expect(result.success).toBe(false) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.