Skip to content

fix(typecheck): narrow hook event counts #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevincodex1 merged 1 commit into from
Jun 4, 2026
Merged

fix(typecheck): narrow hook event counts #1496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/components/hooks/HooksConfigMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ type ModeState = {
event: HookEvent;
hook: IndividualHookConfig;
};
type HooksByEventAndMatcher = Record<
HookEvent,
Record<string, IndividualHookConfig[]>
>;
export function HooksConfigMenu(t0) {
const $ = _c(100);
const {
Expand Down Expand Up @@ -106,7 +110,7 @@ export function HooksConfigMenu(t0) {
} else {
t4 = $[7];
}
const hooksByEventAndMatcher = t4;
const hooksByEventAndMatcher: HooksByEventAndMatcher = t4;
let t5;
if ($[8] !== hooksByEventAndMatcher || $[9] !== selectedEvent) {
t5 = getSortedMatchersForEvent(hooksByEventAndMatcher, selectedEvent);
Expand Down Expand Up @@ -259,7 +263,7 @@ export function HooksConfigMenu(t0) {
const hooksDisabled_1 = settings_1?.disableAllHooks === true;
let t20;
if ($[33] !== hooksByEventAndMatcher) {
const byEvent = {};
const byEvent: Partial<Record<HookEvent, number>> = {};
let total = 0;
for (const [event_0, matchers] of Object.entries(hooksByEventAndMatcher)) {
const eventCount = Object.values(matchers).reduce(_temp5, 0);
Expand Down Expand Up @@ -559,7 +563,7 @@ export function HooksConfigMenu(t0) {
function _temp6() {
return <Text>Esc to close</Text>;
}
function _temp5(sum, hooks) {
function _temp5(sum: number, hooks: IndividualHookConfig[]): number {
return sum + hooks.length;
}
function _temp4(tool) {
Expand Down