fix(status-notices): align warning icons in startup safety notices - #1415
Merged
kevincodex1 merged 1 commit intoMay 28, 2026
Merged
Conversation
chioarub
marked this pull request as ready for review
May 28, 2026 07:27
kevincodex1
approved these changes
May 28, 2026
discopops
pushed a commit
to discopops/openclaude
that referenced
this pull request
May 28, 2026
Gravirei
added a commit
to Gravirei/openclaude
that referenced
this pull request
May 28, 2026
- fix(autocompact): retry circuit breaker after cooldown (Twigpine#1375) - fix(provider): require API key input when adding OpenGateway (Twigpine#1384) - fix(provider): allow remote Ollama without OPENAI_API_KEY (Twigpine#952) - fix(codex-stream): recover tool args delivered only via done events (Twigpine#1262) - fix: route MiniMax compacting through Anthropic-compatible API (Twigpine#1154) - fix(thinking): disable thinking for unsupported Ollama models (Twigpine#1376) - feat(agents): set active session agent from agents menu (Twigpine#1349) - fix(repl): show permission prompts while draft input is present (Twigpine#1393) - fix(model): include profile models in descriptor picker (Twigpine#1361) - Improve warning notice formatting (Twigpine#1415) - fix(codex): allow credential storage fallback (Twigpine#1347) - fix(attribution): make git attribution opt-in by default (Twigpine#1335) - fix(agent): allow custom model overrides (Twigpine#1337) - feat(query): robust multi-lingual and structural continuation nudge (Twigpine#1280) - fix(watchers): debounce skills and settings reload bursts (Twigpine#1370) - feat: configure API retry backoff (Twigpine#370) (Twigpine#1095) - chore(main): release 0.15.0 (Twigpine#1325) - ci: retrigger CodeQL after action download outage (Twigpine#1374) - Fix launcher heap setup for long sessions (Twigpine#1242)
hotmanxp
added a commit
to hotmanxp/openclaude
that referenced
this pull request
Jun 2, 2026
…Twigpine#1415) Every status notice duplicated the same wrapping <Box flexDirection="row"> + <Text color="warning">{figures.warning}</Text> boilerplate, which made the spacing between the icon and the message inconsistent and forced \ttext wrapping to fight the icon column. Extracting WarningNoticeRow gives every warning notice a guaranteed 1-column gutter and a shrinkable text column. Also split the third-party and --dangerously-skip-permissions notices into a primary line and a dimColor sub-line, so the headline fits on one line and the qualifier is visually de-emphasized. Rebase onto current main (fabb148 → OpenCC 0.14.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WarningNoticeRowfor startup status notices so warning icons have a stable gap before text and wrapped lines align under the message column.bypassPermissionsand--dangerously-skip-permissionsnotices at an 80-column width.Why
The permission safety warnings could render as
⚠bypassPermissionsor⚠--dangerously-skip-permissions, which made high-risk startup notices look cramped and less polished. Centralizing the warning row layout fixes the immediate spacing issue and prevents the same icon/text adjacency problem across other warning notices.Validation
bun install --frozen-lockfilebun install --cwd web --frozen-lockfilebun run smokeenv -u CLAUDE_CODE_USE_OPENAI -u OPENAI_MODEL -u OPENAI_BASE_URL -u OPENAI_API_BASE -u OPENAI_API_KEY -u GEMINI_API_KEY -u GOOGLE_API_KEY -u GEMINI_ACCESS_TOKEN -u GOOGLE_APPLICATION_CREDENTIALS -u GOOGLE_CLOUD_PROJECT -u GCLOUD_PROJECT -u MIMO_API_KEY -u ANTHROPIC_API_KEY -u ANTHROPIC_AUTH_TOKEN HOME="$CI_HOME" METADATA_SERVER_DETECTION=none bun test --max-concurrency=1(3015 pass, 0 fail)python -m pip install -r python/requirements.txt && python -m pytest -q python/tests(44 passed)bun run security:pr-scan -- --base origin/mainenv -u CLAUDE_CODE_USE_OPENAI -u OPENAI_MODEL -u OPENAI_BASE_URL -u OPENAI_API_BASE -u OPENAI_API_KEY -u GEMINI_API_KEY -u GOOGLE_API_KEY -u GEMINI_ACCESS_TOKEN -u GOOGLE_APPLICATION_CREDENTIALS -u GOOGLE_CLOUD_PROJECT -u GCLOUD_PROJECT -u MIMO_API_KEY -u ANTHROPIC_API_KEY -u ANTHROPIC_AUTH_TOKEN METADATA_SERVER_DETECTION=none bun run test:provider(609 pass, 0 fail)env -u CLAUDE_CODE_USE_OPENAI -u OPENAI_MODEL -u OPENAI_BASE_URL -u OPENAI_API_BASE -u OPENAI_API_KEY -u GEMINI_API_KEY -u GOOGLE_API_KEY -u GEMINI_ACCESS_TOKEN -u GOOGLE_APPLICATION_CREDENTIALS -u GOOGLE_CLOUD_PROJECT -u GCLOUD_PROJECT -u MIMO_API_KEY -u ANTHROPIC_API_KEY -u ANTHROPIC_AUTH_TOKEN METADATA_SERVER_DETECTION=none npm run test:provider-recommendation(78 pass, 0 fail)bun run --cwd web typecheck && bun run --cwd web buildNote: the full Bun suite was run with provider credentials unset and metadata probing disabled to match CI more closely; the local shell has provider and Google ADC state that changes unrelated tests.