-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive list of false positives #75
base: master
Are you sure you want to change the base?
Conversation
Update falsepositives.go - incumbent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm overreaching a bit, but that word made me think of encumber
too.
Could you add encumber
to the list of false positives too? 🙏
@coggsflod Let me know when you've completed the requested change 🙏 |
@TwiN I decided to create a comprehensive false positive list based upon an english dictionary of non-profane words. I should have a revised PR with a complete list available in the next couple of days. |
Done! |
Hey @TwiN, I wanted to see if we're good to merge? |
Hey, sorry about the delay. I think you misunderstood how false positives work. Adding "assault" would cover for assault* (assault, assaulting, assaults, assaulting, etc.), but instead, you explicitly added every word prefixed by assault. |
Summary
Checklist
README.md
, if applicable.