feat(security): added the ability to use a different claim field to match against the allow-subjects list. #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch against the allow-subjects list. In this way you can use 'email' or 'preferred_username' to identify the users. If not specified the default is 'subject'.
|
@TwiN can you take a look in this PR? |
TwiN
requested changes
Jul 27, 2024
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #763 +/- ##
==========================================
- Coverage 78.92% 78.63% -0.29%
==========================================
Files 69 69
Lines 4521 4536 +15
==========================================
- Hits 3568 3567 -1
- Misses 754 769 +15
- Partials 199 200 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
You can use a custom claim field to identify users i.e. 'email' or 'preferred_username'.
If not specified the default is 'subject'.
Checklist
README.md, if applicable.##Notes
Tested using a keycloak server as OIDC provider.
I tried to add some unit tests but I'm not sure how to mock a valid OIDC server.