fix: Use privileged mode for ICMP only on Windows

[TwiN]

Summary

Use privileged mode for ICMP only on Windows

Fixes #697

Checklist

• Tested and/or added tests to validate that the changes work as intended, if applicable.
• Updated documentation in README.md, if applicable.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.58%. Comparing base (2833968) to head (a3f3660).
Report is 22 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   80.63%   80.58%   -0.05%     
==========================================
  Files          64       64              
  Lines        4244     4244              
==========================================
- Hits         3422     3420       -2     
- Misses        624      625       +1     
- Partials      198      199       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TwiN]

Temporarily published container image as twinproduction/gatus:experimental for testing purposes.

[h3mmy]

I've verified that this works in my environment for the icmp check. Details here: #697 (comment)

[h3mmy]

LGTM. Thanks for making this change!

[TwiN]

FYI this is on-hold and is being discussed in #697

[ignisf]

Hya, just chiming in that this fixes ICMP with rootless podman containers. As does adding the CAP_NET_RAW capability with the stable branch.

[h3mmy]

Is there anything specifically preventing this from being merged?

[TwiN]

@h3mmy #697 (comment) is why I'm not merging it.

#697 (comment) is the reason why this needs more investigation.

The fix itself resolves an issue for some people, but causes more issues for other people. This still needs some investigation, and I don't have the time to spend on this at the moment. Also worth pointing out that for me, the current release works just fine, but the fix does not unless I add

      securityContext:
        sysctls:
          - name: net.ipv4.ping_group_range
            value: 0 65536

to the pod security context, which means that this would technically be a regression for my cloud environment, and likely others.