Correct includes value in library.properties #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The includes field in library.properties is used to customize which #include directives will be added to the sketch by the Arduino IDE via Sketch > Include Library > esp8266-wifi-picker. For this reason, the previous includes value was incorrect. The includes field is only supported by Arduino IDE 1.6.10 and newer and those IDE versions do not require you to add #include directives for library dependencies so there is no need to have FS.h,ESP8266WiFi.h,WiFiClient.h,DNSServer.h,map in the includes field. What is needed in the includes field is WiFiPicker.h, which I have added in lieu of the unnecessary file names.
Owner
|
Oops I thought those were dependencies |
Contributor
Author
|
Unfortunately there is not a library dependencies functionality yet in the Arduino IDE. There has been some work on adding this (arduino/Arduino#6004) but it hasn't been merged in yet. It looks like they are leaning towards naming the field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
includesfield in library.properties is used to customize which#includedirectives will be added to the sketch by the Arduino IDE via Sketch > Include Library > esp8266-wifi-picker. For this reason, the previousincludesvalue was incorrect.The
includesfield is only supported by Arduino IDE 1.6.10 and newer and those IDE versions do not require you to add#includedirectives for library dependencies so there is no need to haveFS.h,ESP8266WiFi.h,WiFiClient.h,DNSServer.h,mapin theincludesfield.What is needed in the
includes field is WiFiPicker.h, which I have added in lieu of the unnecessary file names.