Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve particle samplers warning message #900

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

yebai
Copy link
Member

@yebai yebai commented Aug 30, 2019

This PR adds a bit of warning information for illy defined posteriors, e.g.

  @model normal() = begin
    a ~ Normal(4,5)
    b ~ Normal(a,1)
    n ~ Categorical(3)
    for i=1:n # random number of observations
       n ~ Normal(a,b)
    end
  end

  tested = sample(normal(), SMC(10))

@yebai yebai requested review from trappmartin and xukai92 August 30, 2019 12:13
@yebai yebai changed the title Improve particle samplers warning message [WIP] Improve particle samplers warning message Aug 30, 2019
src/core/container.jl Outdated Show resolved Hide resolved
src/core/container.jl Outdated Show resolved Hide resolved
src/core/container.jl Outdated Show resolved Hide resolved
test/inference/smc.jl Outdated Show resolved Hide resolved
@yebai
Copy link
Member Author

yebai commented Sep 2, 2019

Prerequisite: TuringLang/Libtask.jl#41

@yebai yebai force-pushed the hg/improve-particle-samplers branch from d004a57 to eb3ac31 Compare April 15, 2020 16:07
@yebai yebai changed the title [WIP] Improve particle samplers warning message Improve particle samplers warning message Apr 15, 2020
@yebai
Copy link
Member Author

yebai commented Apr 15, 2020

Ready for another review @trappmartin

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #900 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   65.91%   65.99%   +0.07%     
==========================================
  Files          25       25              
  Lines        1282     1282              
==========================================
+ Hits          845      846       +1     
+ Misses        437      436       -1     
Impacted Files Coverage Δ
src/core/container.jl 94.79% <100.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8342103...eb3ac31. Read the comment docs.

@yebai
Copy link
Member Author

yebai commented Apr 15, 2020

I'm merging now since there is no functionality in this PR and all the tests are passing.

@yebai yebai merged commit 6f44f01 into master Apr 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the hg/improve-particle-samplers branch April 15, 2020 20:21
phipsgabler pushed a commit to phipsgabler/Turing.jl that referenced this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants