Use set_valid_worlds! instead of manual optimisation#205
Merged
Conversation
|
Libtask.jl documentation for PR #205 is available at: |
Member
Author
|
After some optimisations provided by @Technici4n, the benchmarks on this branch are now on par with That makes this ready for review. |
Member
|
great work, both! |
Member
Author
|
This really all @Technici4n, I just copied over some of his code from Mooncake/Slack and added comments. Thank you! |
Member
|
I think something here broke Turing: https://github.com/TuringLang/Turing.jl/actions/runs/19153277686/job/54748336850?pr=2710 |
This was referenced Nov 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicating the changes made to Mooncake by in chalk-lab/Mooncake.jl#832.
The benchmarks that pass, run on this branch:
on
main:and on
mainbut skipping the manual optimisation and just callingmisty_closuredirectly:Two of these are close, but the Rosenbrock one is 230% slower and matrix_test about 60% slower on this branch, and very similar to if I just disable the manual optimisation.