Tapir.jl Usage #319
Merged
Tapir.jl Usage #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
For a start, it is promising that current AD tests pass without any issues! |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yebai
reviewed
Jun 27, 2024
yebai
reviewed
Jun 27, 2024
Collaborator
Author
|
@yebai okay, this could in principle now be merged. Since Tapir.jl can't be installed on 1.6, I've had to install it conditionally, depending on whether the Julia version is 1.10 or greater. |
devmotion
reviewed
Jun 27, 2024
Merged
yebai
approved these changes
Jul 2, 2024
Collaborator
Author
|
Okay. I think I'm basically happy with this. Once we get the sign off from @devmotion , if someone could please merge this (I don't have commit rights). |
devmotion
reviewed
Jul 2, 2024
Co-authored-by: David Widmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#318 made me intrigued to see how well Tapir.jl fares on Bijectors.jl. It looks like I just need to make use of Bijectors.jl's rule for
find_alpha(a wrapper for a bisection routine) in order to make the tests pass, which is nice.I'm a little surprised to be honest -- are we confident that the AD tests have decent coverage of the functionality in Bijectors.jl?
edit: test failures on 1.6 are to be expected, because Tapir.jl only supports 1.10 and above.