turf-hexgrid: fix issue #2841 #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typing of mask does not allow for MultiPolygon while the documentation obviously states that this is allowed
twelch
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Changes look good @SimonsUnikaNamn, tests are passing. I'm not seeing any calls within that need to be changed to accept Multipolygon too.
|
Thanks for your contribution. This will become available in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Allowed mask to be of type
Polygon | MultiPolygonTyping of mask does not allow for MultiPolygon while the documentation obviously states that this is allowed
I have read the
preparing a pull requestsection. One unrelated test failed. so I hope my local setup is incorrect and the CI will let this pass