Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Fix sharing of an image multiple times #280

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Fix sharing of an image multiple times #280

merged 2 commits into from
Jul 22, 2020

Conversation

msfjarvis
Copy link
Collaborator

To reproduce the bug:

  1. Open any image
  2. Select the 'Share image' option
  3. Dismiss the share sheet that shows up
  4. Select 'Share image' again
  5. Observe that sharing fails this time

@msfjarvis
Fix sharing of image multiple times
cb29482 
Signed-off-by: Harsh Shandilya <[email protected]>
@msfjarvis
Update changelog
c5e993a 
Signed-off-by: Harsh Shandilya <[email protected]>
Tunous
Tunous approved these changes Jul 22, 2020
View reviewed changes
Copy link
Owner

@Tunous Tunous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I've reproduced the bug and indeed this fixes it correctly. Thanks.

@Tunous Tunous merged commit 4ead42e into Tunous:master Jul 22, 2020
@Tunous Tunous added this to the 0.9.3 milestone Jul 22, 2020
@Tunous Tunous added the bug Something isn't working label Jul 22, 2020
@Tunous Tunous mentioned this pull request Jul 22, 2020
Closed
@msfjarvis msfjarvis deleted the bug/image-share branch July 22, 2020 16:54
@msfjarvis msfjarvis changed the title Fix sharing of image multiple times Fix sharing of an image multiple times Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tunous Tunous Tunous approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msfjarvis @Tunous