This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Always show fullsize imgur images #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tunous
reviewed
May 19, 2020
| // Strip any preview-related suffixes and queries | ||
| imageUrl = imageUrl.newBuilder() | ||
| .encodedQuery(null) | ||
| .encodedPath(imgurPreviewPat.matcher(imageUrlPath).replaceFirst(".")) |
There was a problem hiding this comment.
It probably won’t occur but what if that pattern was found earlier than before extension? Maybe it’s better to replace last occurrence instead.
There was a problem hiding this comment.
Using java's matcher this can only be done by a more precise regex. Something like s/_d(\.\w+)$/$1/
|
yes, I'll add test cases for this |
AbsurdlySuspicious
force-pushed
the
imgur_lowres/feature
branch
from
b5e382d
to
46cfbb6
Compare
|
that should do it |
|
Great, thanks. |
|
By the way, maybe it worth to add |
|
Sounds like a good idea for improvement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submission contains direct imgur url sometimes Dawn were loading preview images.
_dfilename suffix and .webp extension both required to reproduce this. I've added webp as image format and also added stripping of_djust to be safe