Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Fix Imgur images loading #202

Merged
merged 4 commits into from
May 8, 2020

Conversation

AbsurdlySuspicious
Copy link
Collaborator

Seems like Imgur changed their paid api endpoint (very clever of them) and this caused imgur albums and images to stop loading.

Imgur api docs states this:

The Imgur API is free for non-commercial usage. Your application is probably free if you don't plan on making any money with it, or if it's open source.

So i've just changed endpoint to the free one and it works so far (albums/images). I haven't checked uploading yet but according to docs this should work too. But comment in code says:

  /**
   * Get images in an Imgur album. This is a paid API so we try to minimize its usage. The response
   * is wrapped in {@link Response} so that the headers can be extracted for checking Imgur rate-limits.
   */

- so I don't know if I just should update this to new paid endpoint. If we decide to keep free one, then all rate-limit code probably can be removed.

@AbsurdlySuspicious
Copy link
Collaborator Author

I will try to find out how is rate limiting applies to free clients as of now

@AbsurdlySuspicious
Copy link
Collaborator Author

ping @saket

@saket
Copy link

saket commented May 6, 2020

Switching to free endpoints should be fine. I chose to use their paid APIs because Dank wasn't open sourced back then and I had plans to introduce a paid version.

@AbsurdlySuspicious
Copy link
Collaborator Author

Upload works ok. I guess PR is ready to merge

@AbsurdlySuspicious
Copy link
Collaborator Author

@saket I think mashape token can be invalidated after merge. Old clients won't work due to endpoint change anyway

@Tunous Tunous merged commit a184a9d into Tunous:master May 8, 2020
@Tunous
Copy link
Owner

Tunous commented May 8, 2020

Thanks, merged :)

@AbsurdlySuspicious AbsurdlySuspicious deleted the fix_imgur_api/feature branch May 18, 2020 21:17
@Tunous Tunous added the bug Something isn't working label Aug 2, 2020
@Tunous Tunous added this to the 0.9.2 milestone Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants