Add speechmatics #1
Conversation
jamied157
left a comment
jamied157
left a comment
There was a problem hiding this comment.
Looks good, few small things in the examples and I don't know how we deal with sample rate
speech_recognition/__init__.py
Outdated
| raise RequestError("missing speechmatics python module: install using `pip install speechmatics-python`") | ||
|
|
||
| wav_data = audio_data.get_wav_data( | ||
| convert_rate=None if audio_data.sample_rate >= 16000 else 16000 # audio samples must be at least 16 kHz |
There was a problem hiding this comment.
You might know better than me - is this correct? Do we deal with sample rate >= 16000 ourselves?
There was a problem hiding this comment.
Not sure, let me check with some of the heads
There was a problem hiding this comment.
I asked Dan, he reckons we don't get anything less than 8000, but may be able to support lower than that. It's not documented anywhere that I can see. Maybe we just let the runtime deal with it and pass any errors to users?
There was a problem hiding this comment.
Yeah sounds good to me, we can keep an eye on the repo and see if anyone is having issues if it gets merged
There was a problem hiding this comment.
Removed that now, will resolve and merge and then open a PR into the upstream
No description provided.