Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Improve AdwAboutWindow #96

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

TheEvilSkeleton
Copy link
Contributor

@TheEvilSkeleton TheEvilSkeleton commented Oct 4, 2022

Licensing

  • I confirm that this is either my code or was released under the terms of a GPLv3-or-later compatible license. Also I agree to release it here under the terms of the GPLv3-or-later.

Description

Disclaimer: I know nothing about Rust.

This improves AdwAboutWindow by adding translator credits, a donation link. It also removes the comment as GNOME discourages from using it.

I still have to add code and designer contributors, if applicable.

Ref. #95

That being said, is there a way I can build a Flatpak manually so I can test it locally?

@Schmiddiii
Copy link
Collaborator

Thanks for the improvements.

I usually do not build it with Flatpak as it needs to recompile everything with dependencies on every recompile. Here are some hints how to do that:

If you have Rust installed (you should if you do not want to re-compile everything including dependencies):

meson build
meson compile -C build
./build/target/debug/tubefeeder

If you don't have Rust installed:

meson build
meson dist --allow-dirty -C build # Will fail, but should generate a `build/meson-dist/tubefeeder-1.9.2.tar.xz`
# Clone https://github.com/flathub/de.schmidhuberj.tubefeeder to somewhere
# Change "url": "https://github.com/Tubefeeder/Tubefeeder/releases/download/v1.9.2/tubefeeder-1.9.2.tar.xz" to "path": "/path/to/the/build/meson-dist/tubefeeder-1.9.2.tar.xz" and remove the "sha256"-line
flatpak-builder --user --install build-dir de.schmidhuberj.tubefeeder.json --force-clean

@Schmiddiii
Copy link
Collaborator

I just talked with the person that made the icon for me and he agreed to be credited. He would probably count as an artist: David Lapshin <[email protected]>

I should probably be in developers (even though I am already in developer-name?).

If you want, you can also add yourself to a section (probably designers would be the best?).

@TheEvilSkeleton
Copy link
Contributor Author

developer-name is typically used for a "generic" group name. For example, "Tubefeeder Developers", "Tubefeeder Contributors", etc.

@TheEvilSkeleton TheEvilSkeleton force-pushed the improve-about-window branch 2 times, most recently from 1a4bb97 to 0e9c839 Compare October 5, 2022 00:55
@Schmiddiii Schmiddiii marked this pull request as ready for review October 5, 2022 12:29
Copy link
Collaborator

@Schmiddiii Schmiddiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just now noticed that the comments I left yesterday were not actually submitted.

data/resources/ui/about.ui.in Outdated Show resolved Hide resolved
data/resources/ui/about.ui.in Show resolved Hide resolved
src/gui/header_bar.rs Outdated Show resolved Hide resolved
@TheEvilSkeleton TheEvilSkeleton marked this pull request as draft October 5, 2022 14:15
Co-authored-by: Schmiddiii <[email protected]>
@TheEvilSkeleton TheEvilSkeleton marked this pull request as ready for review October 5, 2022 14:22
@Schmiddiii Schmiddiii merged commit 8514d6e into Tubefeeder:master Oct 5, 2022
@TheEvilSkeleton TheEvilSkeleton deleted the improve-about-window branch October 5, 2022 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants