🔒 Fixed SVG sanitization for staff profile pictures #21798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes https://linear.app/ghost/issue/ENG-1506 - when uploading a SVG image as staff profile picture, we previously had a validation against malicious `<script>` tags or `on*` attributes - this has proven to be unsufficient, as malicious scripts can be added via other tags (e.g. `<foreignObject>`) and other attributes (e.g. `xlink:href`) - we now satinize SVGs using the DOMPurify library during validation - if the file is invalid and cannot be sanitized, we show an error to the user
sagzy
force-pushed
the
fix/svg-upload-validation
branch
from
a934694 to
1dbee84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/ghost/issue/ENG-1506
<script>tags oron*attributes<foreignObject>) and other attributes (e.g.xlink:href).svgzfiles