🐛 Fixed unclear newsletter (un)subscribe modal #21739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdwinden
force-pushed
the
newsletter-unsubscribe-modal
branch
from
9030793 to
c71add2
Compare
Positioned it at the bottom of the modal.
So we can potentially show them in succession.
Previously, a toast was only shown for 'comments' settings if you reached the modal via the Unsubscribe link. That is solved now.
dvdwinden
force-pushed
the
newsletter-unsubscribe-modal
branch
from
692dea8 to
a58bfb1
Compare
And translated new strings into Dutch.
Checkmarks have been removed, so we have to look for the popup notifications, instead.
It was previously based on being positioned in the bottom of the modal, but it is at the top.
mastoduy
added a commit
to mastoduy/Ghost
that referenced
this pull request
Dec 1, 2024
Portal.json - Added new strings from newsletter (un)subscribe modal (TryGhost#21739) - Correct the spelling mistake of missing a [t] character in the sentence
kevinansfield
pushed a commit
that referenced
this pull request
Dec 18, 2024
no issue Portal.json - Added new strings from (#21739) - Corrected the spelling mistake of missing a `t` character in the sentence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://linear.app/ghost/issue/DES-953/newsletter-unsubscribe-modal-is-unclear-leading-to-repeated
Previously, when clicking 'Unsubscribe' in an email, landing on this modal it was unclear what had just happened if you didn't read the text below the title, causing people to click the toggles repeatedly.
We've now added a notification to make it clear what has just happened, and if you click the toggles, the notification also shows.
Ideally, we'd be able to stack these notifications in case you hit multiple toggles in quick succession, but that's going to be a separate issue, as—to achieve that—it needs to be rewritten more significantly.
unsubscribe-after.mp4