Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Korean. #21577

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Complete Korean. #21577

merged 2 commits into from
Nov 12, 2024

Conversation

hellosunghyun
Copy link
Contributor

@hellosunghyun hellosunghyun commented Nov 9, 2024 •
edited
Loading

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

cathysarisky
cathysarisky suggested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment on selecting a name for Jamie Larson, rather than transliterating. Everything else look good to an AI inspection.

ghost/i18n/locales/ko/portal.json Outdated Show resolved Hide resolved
@hellosunghyun
Copy link
Contributor Author

Complete!

@ronaldlangeveld
Copy link
Member

ronaldlangeveld commented Nov 12, 2024 •
edited
Loading

안녕하세요 성현 @hellosunghyun :)
Thank you very much for your ongoing translations! 🙏🏻 You may find a few more strings to translate—if you come across any that need work in 한국어, don’t hesitate to reach out! 🎉

@ronaldlangeveld ronaldlangeveld merged commit 7c70c06 into TryGhost:main Nov 12, 2024
21 checks passed
9larsons pushed a commit that referenced this pull request Nov 13, 2024
@hellosunghyun @9larsons
🌐 Added Korean i18n translations (#21577)
0765d33 
ref ONC-557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathysarisky cathysarisky cathysarisky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellosunghyun @ronaldlangeveld @cathysarisky