Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local French additions and improvements #21498

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Local French additions and improvements #21498

merged 3 commits into from
Nov 7, 2024

Conversation

bst1n
Copy link
Contributor

@bst1n bst1n commented Nov 1, 2024

It's difficult out of context to know whether to use an infinitive, Ajouter votre commentaire or an imperative, Ajoutez votre commentaire. English doesn't make the difference, but French does. By default, an infinitive is preferable because it remains a suggestion, whereas an imperative gives an order. For example, I think that Ajoutez votre commentaire is not relevant, because you don't necessarily have to add a comment, but you can, so you should say Ajouter votre commentaire. I've tried to be as precise as possible, but you may need to make some adjustments with the context.

I find that the word membre is too literal a translation of the English language and includes too many innuendos such as "member of a community", "member of a clan", "member of a club", and frankly, it's not relevant to many blogs. The word abonné is more relevant, because it doesn't imply a social affiliation. As for the discussion, I've even taken the liberty of writing discussion entre lecteurs, because that's essentially what it is. It's not a discussion between members or subscribers, it's a discussion between readers.

Some placeholders are completely American (Jamie Larson), so I've replaced him with a French one (Jean Martin).

Complimentary is a word that I didn't understand in the context of Ghost. I have the impression that it means offert, but I don't understand when it's used.

@cathysarisky
Copy link
Contributor

cathysarisky commented Nov 1, 2024

Complimentary here means that the member (reader!) has access to a paid tier, but isn't actually paying. It means that you (the site owner) have given them a paid access level that they aren't actually paying for.

The placeholder name appears in several other files also. It's totally fine to make it French, but we should probably do it everywhere. Oh, nevermind, I see that you did! :)

Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these!

Copy link
Contributor

@sagzy sagzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bst1n, thanks for the PR! All great changes 💯

I have added one comment on the term "lecteur" versus "abonné"

ghost/i18n/locales/fr/comments.json Outdated Show resolved Hide resolved
@sagzy sagzy enabled auto-merge (squash) November 7, 2024 15:32
@sagzy sagzy merged commit 2806236 into TryGhost:main Nov 7, 2024
20 checks passed
9larsons pushed a commit that referenced this pull request Nov 13, 2024
ref https://ghost.org/changelog/internationalization/

- It's difficult out of context to know whether to use an infinitive,
_Ajouter votre commentaire_ or an imperative, _Ajoutez votre
commentaire_. English doesn't make the difference, but French does. By
default, an infinitive is preferable because it remains a suggestion,
whereas an imperative gives an order. For example, I think that _Ajoutez
votre commentaire_ is not relevant, because you don't necessarily have
to add a comment, but you can, so you should say _Ajouter votre
commentaire_. I've tried to be as precise as possible, but you may need
to make some adjustments with the context.

- I find that the word _membre_ is too literal a translation of the
English language and includes too many innuendos such as "member of a
community", "member of a clan", "member of a club", and frankly, it's
not relevant to many blogs. The word _abonné_ is more relevant, because
it doesn't imply a social affiliation. As for the discussion, I've even
taken the liberty of writing _discussion entre lecteurs_, because that's
essentially what it is. It's not a discussion between members or
subscribers, it's a discussion between _readers_.

- Some placeholders are completely American (Jamie Larson), so I've
replaced him with a French one (Jean Martin).

- Complimentary is a word that I didn't understand in the context of
Ghost. I have the impression that it means _offert_, but I don't
understand when it's used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants