✨New helper: content_api_url #21331
Merged
✨New helper: content_api_url #21331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathysarisky
changed the title
cathysarisky
changed the title
allouis
reviewed
Oct 23, 2024
| } | ||
| } | ||
|
|
||
| module.exports.async = true; |
There was a problem hiding this comment.
I don't think this needs to be an async helper! It will be much more performant without it!
There was a problem hiding this comment.
You're also missing a newline at the bottom of this file - I would recommend installing an EditorConfig plugin for your editor
cathysarisky
changed the title
allouis
pushed a commit
to TryGhost/gscan
that referenced
this pull request
Oct 25, 2024
refs TryGhost/Ghost#21331 We need to make sure that theme developers are able to use the new helpers without gscan errors!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a content_api_url helper, returning the url for Ghost's content api. Takes a false argument if a relative URL is wanted.
Why? Because I just realized I don't have access to the content API's url in handlebars. :) This addition will facilitate 3rd party integrations built into themes.
Companion PR for gscan: TryGhost/gscan#558