🐛 fixed routing error when no recommendations #21251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike182uk
reviewed
Oct 16, 2024
mike182uk
reviewed
Oct 21, 2024
|
Thanks for this @cathysarisky |
|
This is what I use in PHP to filter variables, if anyone can translate it, it would be a game changer. this prevents SQL Injections, XSS, CRSF.
2VDYWtEqsM94LzFs.mp4Thanks, MIT Researcher. |
dvdwinden
pushed a commit
that referenced
this pull request
Oct 24, 2024
no ref. The default routing for the portal app is a signup page. When a site has no recommendations, the result of triggering that page (by following a link that goes there) is a prompt to sign up, or a notification that one cannot sign up, if membership is disabled. This patch adds a "No recommendations" message, which will be shown if a user follows a recommendations link (#/portal/recommendations) on a site without recommendations. While we shouldn't end up there very often, it'll make a lot more sense when it does!
Lekler
added a commit
to Lekler/Ghost
that referenced
this pull request
Nov 1, 2024
…t adds pt-BR translations to newsletter.json and fixes other strings in pt-BR locale files. Changes to be committed: modified: ghost/i18n/locales/pt-BR/ghost.json modified: ghost/i18n/locales/pt-BR/newsletter.json modified: ghost/i18n/locales/pt-BR/portal.json
sagzy
pushed a commit
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no ref.
The default routing for the portal app is a signup page. When a site has no recommendations, the result of triggering that page (by following a link that goes there) is a prompt to sign up, or a notification that one cannot sign up, if membership is disabled.
This patch adds a "No recommendations" message, which will be shown if a user follows a recommendations link (#/portal/recommendations) on a site without recommendations. While we shouldn't end up there very often, it'll make a lot more sense when it does!
Correction: This fix does not close #20771 - that's a separate bug!