This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Improve uploader tests + test subscribers CSV import #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue - override `x-file-input` in `gh-file-input` to look for a custom property on the change event if we are in testing mode (this is necessary because Ember 2.5+ use native rather than jQuery events so `target.files` is readonly, see emberjs/ember.js#13540) - migrate unit tests for the uploader components to the integration tests - add skipped acceptance tests for the subscribers CSV import now that it's possible to simulate file uploads
kevinansfield
force-pushed
the
improve-file-upload-tests
branch
from
a5e676d
to
3ce26bc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
x-file-inputingh-file-inputto look for a custom property on the change event if we are in testing mode (this is necessary because Ember 2.5+ use native rather than jQuery events sotarget.filesis readonly, see Issue with new native event test helpers in Ember 2.5.1 emberjs/ember.js#13540)