Skip to content

Commit

Permalink
test: cover vm with negative tests
Browse files Browse the repository at this point in the history
Test the impossibility of creating
an abstract instance of the Module.
Test of SyntheticModule to throw exception
if invalid params in constructor

PR-URL: nodejs#31028
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
  • Loading branch information
Andrew Kuzmenko authored and Trott committed Dec 22, 2019
1 parent ea6a457 commit ee14a64
Showing 1 changed file with 41 additions and 1 deletion.
42 changes: 41 additions & 1 deletion test/parallel/test-vm-module-basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@

const common = require('../common');
const assert = require('assert');
const { SourceTextModule, SyntheticModule, createContext } = require('vm');
const {
Module,
SourceTextModule,
SyntheticModule,
createContext
} = require('vm');
const util = require('util');

(async function test1() {
Expand Down Expand Up @@ -107,3 +112,38 @@ const util = require('util');
assert.notStrictEqual(dep, undefined);
assert.strictEqual(dep, m.dependencySpecifiers);
}

// Check the impossibility of creating an abstract instance of the Module.
{
common.expectsError(() => new Module(), {
message: 'Module is not a constructor',
type: TypeError
});
}

// Check to throws invalid exportNames
{
common.expectsError(() => new SyntheticModule(undefined, () => {}, {}), {
message: 'The "exportNames" argument must be an Array of strings.' +
' Received undefined',
type: TypeError
});
}

// Check to throws invalid evaluateCallback
{
common.expectsError(() => new SyntheticModule([], undefined, {}), {
message: 'The "evaluateCallback" argument must be of type function.' +
' Received undefined',
type: TypeError
});
}

// Check to throws invalid options
{
common.expectsError(() => new SyntheticModule([], () => {}, null), {
message: 'The "options" argument must be of type object.' +
' Received null',
type: TypeError
});
}

0 comments on commit ee14a64

Please sign in to comment.