tools: enforce loading required modules first

Refs: nodejs#7786
Trott · Jul 22, 2016 · bc591e9 · bc591e9
1 parent 6123075
commit bc591e9
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/tools/eslint-rules/required-modules.js b/tools/eslint-rules/required-modules.js
@@ -1,5 +1,6 @@
 /**
- * @fileoverview Require usage of specified node modules.
+ * @fileoverview Require usage of specified node modules before any other
+ * modules are loaded.
  * @author Rich Trott
  */
 'use strict';
@@ -63,11 +64,16 @@ module.exports = function(context) {
 
   return {
     'CallExpression': function(node) {
-      if (isRequireCall(node)) {
+      if (isRequireCall(node) && foundModules.length < requiredModules.length) {
         var requiredModuleName = getRequiredModuleName(node);
 
         if (requiredModuleName) {
           foundModules.push(requiredModuleName);
+        } else {
+          context.report(
+            node,
+            'Module loaded before all required modules loaded.'
+          );
         }
       }
     },
@@ -89,11 +95,3 @@ module.exports = function(context) {
     }
   };
 };
-
-module.exports.schema = {
-  'type': 'array',
-  'additionalItems': {
-    'type': 'string'
-  },
-  'uniqueItems': true
-};