process: properly close file descriptor on exit

This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. PR-URL: nodejs#24972 Refs: https://github.com/nodejs/node/pull/24965/files#r240770314 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Trott · Dec 14, 2018 · 80ab537 · 80ab537
1 parent 49f1db4
commit 80ab537
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/internal/process/warning.js b/lib/internal/process/warning.js
@@ -29,7 +29,9 @@ function writeOut(message) {
 function onClose(fd) {
   return () => {
     if (fs === null) fs = require('fs');
-    fs.close(fd, nop);
+    try {
+      fs.closeSync(fd);
+    } catch {}
   };
 }