Skip to content

Commit

Permalink
test: increase limit for network space overhead test
Browse files Browse the repository at this point in the history
This test imposes a limit on the average bytes of space per chunk
for network traffic. However this number depends on VM
implementation details, and upcoming changes to V8's
array buffer management require a small bump to this
limit in this test.

PR-URL: nodejs#28492
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
Ben L. Titzer authored and addaleax committed Jul 14, 2019
1 parent 056b0bd commit 2550ddb
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ process.on('exit', () => {
const bytesPerChunk =
(process.memoryUsage().rss - baseRSS) / receivedChunks.length;
// We should always have less than one page (usually ~ 4 kB) per chunk.
assert(bytesPerChunk < 512, `measured ${bytesPerChunk} bytes per chunk`);
assert(bytesPerChunk < 600, `measured ${bytesPerChunk} bytes per chunk`);
});

0 comments on commit 2550ddb

Please sign in to comment.