Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsprim dependency to v 2.0.1 #124

Closed
wants to merge 1 commit into from
Closed

Upgrade jsprim dependency to v 2.0.1 #124

wants to merge 1 commit into from

Conversation

BruceHaley
Copy link

@BruceHaley BruceHaley commented Nov 16, 2021

As noted in issue #123, http-signature has a critical severity vulnerability brought in by a transitive dependency through jsprim on json-schema v0.2.3.

node-jsprim has a pull request which fixes the vulnerability.

This dependency upgrade to jsprim ^2.0.1 assumes the vulnerability fix will be released in jsprim version 2.0.n. Thus, http-signature would be positioned to receive that fix and pass it up the dependency chain whenever the jsprim patch is released.

This would improve the security of our Bot Framework samples and I expect a lot of other products. A typical dependency tree of our sample bots is:

[email protected] C:\src\BotBuilder-Samples\samples\typescript_nodejs\02.echo-bot
-- [email protected]
  -- [email protected]
    -- [email protected]
      -- [email protected]

@BruceHaley
Copy link
Author

Obsoleted by #125

@BruceHaley BruceHaley closed this Nov 17, 2021
@BruceHaley BruceHaley deleted the brucehaley-issue123-nov15 branch November 17, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant