TOOLS-2468 jr should check for teams access #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if we should go to town here and add a new subcommand to add teams to repos. What do you think? |
trentm
suggested changes
Jun 2, 2020
There was a problem hiding this comment.
triton-dev: error (access.missing_permission): Joyent team "joyent-engineering" was present, but was missing "push" ("Write" in the GUI) permission. Fix this via "Manage Access"
Is slightly misleading when @joyent-engineering currently has "Admin" access per https://github.com/joyent/triton-dev/settings/access
It would perhaps be nice to give the access URL rather than via "Manage Access"?
| function checkEngineeringTeamsAccess(ctx, next) { | ||
| checkTeamAccess('joyent-engineering', 'push', ctx, next); | ||
| }, | ||
| function checkOwnersTeamsAccess(ctx, next) { |
There was a problem hiding this comment.
Definitely want to drop this one. See comment on the ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.