-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR test #46
base: master
Are you sure you want to change the base?
PR test #46
Conversation
Test some changes here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review was conducted with joy on GitContext.com
@@ -25,7 +25,7 @@ COLOR_RESET="\033[0m" | |||
|
|||
STRING_1="LINK RECONNECTED: " | |||
STRING_2="LINK DOWN: " | |||
STRING_3="TOTAL DOWNTIME: " | |||
STRING_3="TOTAL DOWNTIME IN SECONDS: " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should show an ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review was conducted with joy on GitContext.com
@@ -63,16 +63,6 @@ PRINT_MANAGESERVICE() { | |||
PRINT_HR | |||
} | |||
|
|||
PRINT_INSTALL() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should have removed this block of code.
@@ -155,6 +145,26 @@ START_WEBSERVER() { | |||
esac | |||
} | |||
|
|||
SETUP_SERVER() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review was conducted with joy on GitContext.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review was conducted with joy on GitContext.com
@@ -25,7 +25,7 @@ COLOR_RESET="\033[0m" | |||
|
|||
STRING_1="LINK RECONNECTED: " | |||
STRING_2="LINK DOWN: " | |||
STRING_3="TOTAL DOWNTIME: " | |||
STRING_3="TOTAL DOWNTIME IN SECONDS: " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it has another comment.
Test some changes here.