-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G4.114 Finalize processValidationMessages() to generate user-friendly messages #127
Draft
carolyncaron
wants to merge
41
commits into
4.x
Choose a base branch
from
g4.114-updateProcessMessages
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,242
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolyncaron
changed the title
Finalize processValidationMessages() to generate user-friendly messages
G4.114 Finalize processValidationMessages() to generate user-friendly messages
Nov 22, 2024
…ne 487 in formValidateTest as expected
…eorganized new code to fix a bug.
…palCultivate/TripalCultivate-Phenotypes into g4.114-updateProcessMessages
…x broken tests :(
…eedback Update feedback engine template
…menting new process methods
…mcrawler outputs html differently.
…palCultivate/TripalCultivate-Phenotypes into g4.114-updateProcessMessages
…palCultivate/TripalCultivate-Phenotypes into g4.114-updateProcessMessages
…palCultivate/TripalCultivate-Phenotypes into g4.114-updateProcessMessages
…age process methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #114
Dependent on PR #123
Motivation
This PR is meant to tackle changes needed to processValidationMessages() in the Traits Importer. Once the feedback validation engine has been upgraded to expect a render array to display validation errors to the user, then processValidationMessages() is updated to create those render arrays for each validator that fails.
What does this PR do?
$failures[$validator_name]
and plugs them into the appropriate places of the render array, and finally returns the finished render array.Testing
Automated Testing
Please describe each automated test this PR creates and provide a list of the assertions it makes using casual language.
Do not just say things like "asserts the array is not empty" but rather say "Ensures that the return value of method X with these parameters is not an empty array".
ClassName->testSpecificBug: tests this specific bug
Manual Testing
Describe in detail how someone should manually test this functionality.
Make sure to include whether they need to build a docker from scratch, create any records, etc.