Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G4.114 Finalize processValidationMessages() to generate user-friendly messages #127

Draft
wants to merge 41 commits into
base: 4.x
Choose a base branch
from

Conversation

carolyncaron
Copy link
Contributor

Issue #114

Dependent on PR #123

Motivation

This PR is meant to tackle changes needed to processValidationMessages() in the Traits Importer. Once the feedback validation engine has been upgraded to expect a render array to display validation errors to the user, then processValidationMessages() is updated to create those render arrays for each validator that fails.

What does this PR do?

  1. For each validator that is instantiated by the Traits Importer, create a new method that chooses the appropriate render array type/markup, takes the contents of $failures[$validator_name] and plugs them into the appropriate places of the render array, and finally returns the finished render array.
  2. Update processValidationMessages() to no longer loop through all of the failed validators, and instead checks each validator if a failure occurred and calls the correct method to build the render array.

Testing

Automated Testing

Please describe each automated test this PR creates and provide a list of the assertions it makes using casual language.
Do not just say things like "asserts the array is not empty" but rather say "Ensures that the return value of method X with these parameters is not an empty array".

ClassName->testSpecificBug: tests this specific bug

Manual Testing

Describe in detail how someone should manually test this functionality.
Make sure to include whether they need to build a docker from scratch, create any records, etc.

@carolyncaron carolyncaron marked this pull request as draft November 22, 2024 22:39
@carolyncaron carolyncaron changed the title Finalize processValidationMessages() to generate user-friendly messages G4.114 Finalize processValidationMessages() to generate user-friendly messages Nov 22, 2024
carolyncaron and others added 14 commits December 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants