Fix missing share.js in public/app-dist folder; Delete unused public/app folder (Docker build)#3410
Conversation
…app folder (Docker build)
Contributor
|
Thanks for the fix.
I agree, it is currently quite messy and error-prone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, when I enabled the webpack bundle generation in the Docker build I wrongly assumed that share.js would have been bundled as well, well, it's not the case. Looking at copy-trilium.sh it seems like the file is just 'manually' copied to app-dist and then the app folder is wiped.
This PR introduces the same behavior as the copy-trilium.sh script in the Dockerfile.
Should fix: #3409
(Little side-note: Ultimately I think the Docker build should run the same scripts in the bin/ folder to generate Trilium's server edition, instead of replicating the same behavior manually in the Dockerfile which is easily error-prone... This would probably avoid more annoyances like the one this PR solves in the future.)