refactor(session_secret): use existing randomSecureToken function #866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR repalces the
randomValueHex
function (which is not used anywhere else across the codebase) with the already existingrandomSecureToken
function from the utils module for the creation of the session.They both are using the
randomBytes
method of the crypto module.This also improves secret security, as
randomSecureToken
uses Base64 and hence a much larger charset size thanrandomValueHex
(which also unnecessarily was made even a bit more insecure, by having all characters UPPERCASED, so an even smaller charset size).Some examples:
vs previously used secrets
This will only affect newly created newly created session secrets only.