Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a horizontal launcher bar #654

Merged
merged 36 commits into from
Nov 23, 2024
Merged

Add support for a horizontal launcher bar #654

merged 36 commits into from
Nov 23, 2024

Conversation

eliandoran
Copy link
Contributor

@eliandoran eliandoran commented Nov 22, 2024 •
edited
Loading

image

This introduces a new setting which allows switching to a new horizontal layout, where:

  • The launcher bar is no longer on the left of the screen, but on the top.
  • The tab bar also becomes full width.
  • The quick search that used to be in the left pane is now part of the launcher bar, and can be manually positioned just like any other launch bar item.
  • The "Trilium" icon becomes a simple hamburger menu, aligned to the right on both desktop and mobile.
  • On mobile, the current hamburger menu (with two note-specific options) becomes a vertical dot icon similar to a context menu icon. The button is now aligned on the right.

Before:

image

After:

image

On mobile, before:

image

On mobile, after:

image

@eliandoran
refactor(client): add support for optional children in layout
8300acd
@eliandoran
feat(client): implement top launcher pane
efc8472
@eliandoran
feat(client): reorder buttons on horizontal bar
c9f2a2b
@eliandoran
fix(client): fix size for horizontal launcher bar
c858630
@eliandoran
fix(client): experiment with full-width tab bar
d1550db
@eliandoran
feat(client): move tab bar on horizontal layout
91c4ea3
@eliandoran
style(client): improve background for full-width tab bar
15b9f38
@eliandoran
refactor(client): use switch instead of chained-if
045c869
@eliandoran
feat(client): set up quick search as launcher
20b0215
@eliandoran
fix(client): global submenu not working in horizontal layout
50bf948
@eliandoran
feat(client): use hamburger menu for horizontal layout
f62e860
@eliandoran
fix(client): add new tab not working in horizontal layout
13a997b
@eliandoran
fix(client): tooltip position for launcher on horizontal layout
fd8f950
@eliandoran
fix(client): tooltip position for hide left pane button
7e5fea8
@eliandoran
fix(client): dropdown tooltip placement for horizontal layout
5f9439a
@eliandoran
fix(client): dropdown width for horizontal layout
23873b7
@eliandoran
fix(client): global menu alignment on horizontal layout
13e3354
@eliandoran
fix(client): quick search in vertical layout
0f7b96f
@eliandoran
fix(client): tooltip position for calendar in vertical layout
eaa6d6c
@eliandoran
feat(server): add support for layout orientation option
e32f54a
@eliandoran
feat(client): allow user to change layout orientation
4f305b5
@eliandoran
feat(client): respect layout orientation selected by user
62d23b3
@eliandoran
chore(i18n): translate layout settings
23ef2c5
@eliandoran
fix(mobile): fix alignment for horizontal layout
8a61b58
@eliandoran
feat(mobile): hide quick search
d2d2620
@eliandoran
refactor(client): use different hiding mechanism for quick search
91d23ba
@eliandoran
fix(mobile): width of launcher bar items
14fa687
@eliandoran
feat(mobile): move menu button to the right
2dda8f6
@eliandoran
feat(mobile): reorder context menu
ea399e5
@eliandoran
feat(mobile): change context menu icon on horizontal layout
fbae006
@eliandoran eliandoran marked this pull request as ready for review November 23, 2024 12:05
@eliandoran eliandoran merged commit 68fd954 into develop Nov 23, 2024
3 checks passed
@eliandoran eliandoran deleted the feature/adjustable_launcher_bar_position branch November 23, 2024 12:40
@eliandoran eliandoran changed the title Add support for horizontal launcher bar Add support for a horizontal launcher bar Nov 23, 2024
@perfectra1n
Copy link
Contributor

LGTM!!!

@meichthys
Copy link
Contributor

This looks nice. I'm looking forward to trying out the mobile version. The sidebar on the mobile version was severely limiting on-screen real estate.

@mm21
Copy link
Contributor

mm21 commented Nov 25, 2024

Reminds me of your KDE theme, I like it!

@eliandoran eliandoran restored the feature/adjustable_launcher_bar_position branch December 14, 2024 06:56
@eliandoran eliandoran deleted the feature/adjustable_launcher_bar_position branch December 14, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eliandoran @perfectra1n @meichthys @mm21