Feature: user configurable list of allowed html tags in import #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TriliumNext#567 this is the easy method, just add the tags to core, not attempting to read the list from a user configurable location. The addition is clearly marked in code.
todo: test with live app
Bugs remaining: - extra whitespace under heading - existing list is filled with `\n` instead of delimiters - [reset to default] triggers "500 PUT options. Option 'allowedHtmlTags' is not allowed to be changed"
Bugs remaining: - [reset to default] and page exit (e.g. save) triggers: "500 PUT options. Option 'allowedHtmlTags' is not allowed to be changed"
"500 PUT options. Option 'allowedHtmlTags' is not allowed to be changed" Note: the "allowed to change" list is set on startup. When a new option is added Trilium must be restarted.
…t-html-tags ; Conflicts: ; src/routes/api/options.ts ; src/services/options_init.ts
eliandoran
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of #567 whitelist html tags to keep on import.
Created a new configurable option for HTML import tags that:
Made the necessary backend changes:
I tested interactively by running Trilium in a devcontainer using the project docker-compose.yml (no changes outside of the code in this PR).
The feature is believed complete and working, with much help from Windsurf Cascade and Claude Sonnet 3.5. This is the first not-a-toy thing I've done in javascript/typescript, so take that into account during review.
Caveat
The whitelisted tags survive import but only last until the note is Edited, at which time the non-standard ones will be changed to
<p>. So it's present value is in that the import more faithfully represents the source than before. Keeping them after edit too will mean (i assume) changing CKEditor behaviour. I might try look at that, but I expect it's a harder project than this one. so it might be awhile, if ever. (I really miss not having cite tags though, so who knows.)Example:
A onenote cite tag after import (with the change in this PR enabled) looks like:
After being edited the cite changes to: